Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Transform the questions in optional #630

Open
devajmeireles opened this issue Sep 19, 2024 · 7 comments
Open

[Feature Request] Transform the questions in optional #630

devajmeireles opened this issue Sep 19, 2024 · 7 comments

Comments

@devajmeireles
Copy link

Since if I did the PR, it would probably be rejected, I'm sending it as a feature suggestion for someone with more credit than me to do it 😄 Maybe, @MrPunyapal .


Currently, the questions feature is not optional, but some people, like me, may not want to use it, since Pinkary's initial proposal - I think, was for bio links.

My suggestion would be to have the possibility of disabling the questions, and only allowing the idea of sharing updates. So, those who are visitors to our profile will not see this text 👇🏻

Without making this optional, the Pinkary will not be interesting for some people who just want to use the platform for bio links.

CleanShot 2024-09-19 at 10 30 59

@MrPunyapal
Copy link
Collaborator

It's a good Idea 💡

You may proceed 🫡

cc: @nunomaduro

@rahat1994
Copy link

Suppose there is a toggle button on the settings page to enable/disable that feature for individual profiles that would do it. right?

@MrPunyapal
Copy link
Collaborator

Suppose there is a toggle button on the settings page to enable/disable that feature for individual profiles that would do it. right?

Yes, maybe a checkbox. It should be enabled by default. And good tests should make sure they can share updates but others cannot ask them questions.

@rahat1994
Copy link

My Plan:

add a new column to the users table

$table->boolean('questions_enabled')->default(true);

and then reflect this change on the profile page. If you want to name the column anything else just let me know and can you please assign it to me.

@rahat1994
Copy link

Hey @MrPunyapal do I need to do 100% test coverage because Its 99.5%? Files that fail test coverage.

  1. Tests\Unit\Jobs\UpdateUserAvatarTest -> skipped due to windows machine.
  2. app\Livewire\Questions\CreateTest.php

@MrPunyapal
Copy link
Collaborator

MrPunyapal commented Oct 4, 2024

You can ignore that stuff 👌

@rahat1994
Copy link

#687

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants