Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does rocksplicator have rocksdb coloumn family support? #153

Open
anip30 opened this issue Oct 4, 2017 · 6 comments
Open

Does rocksplicator have rocksdb coloumn family support? #153

anip30 opened this issue Oct 4, 2017 · 6 comments

Comments

@anip30
Copy link

anip30 commented Oct 4, 2017

We already have rocksdb instances which uses column family. We want to replicate those using rocksplicator. Is it possible?

@newpoo
Copy link
Contributor

newpoo commented Oct 4, 2017

Multiple column families within the same db instance share the same WAL, and the WriteBatch(BatchResult) read from GetUpdatesSince() has the column family info associated with each Update. So I guess it works for dbs with multiple column families.

@anip30
Copy link
Author

anip30 commented Oct 4, 2017

rocksplicator open the db using "auto s = rocksdb::DB::Open(options, dir, &db);" but if you have coloumn families you need to use
"static Status Open(const DBOptions& db_options, const std::string& name,
const std::vector& column_families,
std::vector<ColumnFamilyHandle*>* handles, DB** dbptr);"

what you think about that?

@newpoo
Copy link
Contributor

newpoo commented Oct 4, 2017

I was talking more about the core replicating logic, which has no problem to replicate DBs with multiple column families. Changes are required in the admin side to support column families. Unfortunately, we don't have any resource to work on it immediately.

@anip30 anip30 closed this as completed Oct 4, 2017
@anip30
Copy link
Author

anip30 commented Oct 10, 2017

I am using only rocksdb_replicator from whole package. Can it replicate DB with Column families without any change in the code? I think it can.

@anip30 anip30 reopened this Oct 10, 2017
@krithikagopalakrishnan
Copy link

Hi @newpoo @anip30 ,

Any updates on whether multiple column families are supported in rocksplicator? If so, how?

Thanks.

@newpoo
Copy link
Contributor

newpoo commented Aug 12, 2019

Unfortunately, we haven't implemented it yet as of today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants