Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

request->need_rounter need to be set by set_need_routing(false) to prevent from infinite recursion #320

Open
zjzzjz1979 opened this issue Sep 24, 2019 · 2 comments
Open

request->need_rounter need to be set by set_need_routing(false) to prevent from infinite recursion #320

zjzzjz1979 opened this issue Sep 24, 2019 · 2 comments

Comments

@zjzzjz1979
Copy link

rocksplicator/examples/counter_service/counter_handler.cpp

Line 131 in 9849fc3

clients[0]->future_setCounter(*request).then(

otherwise reading an undefined key leads to infinite recursion.
@cpd85
Copy link
Contributor

cpd85 commented Sep 24, 2019

its set to false in line 118

@zjzzjz1979
Copy link
Author

Maybe my version of fbthrift is not consistent.

In my case, I need to run request->set_need_routing(false); to make this flag to be false.

I tried both the fbthrift in the docker, and the latest fbthrift. not sure why...

@zjzzjz1979 zjzzjz1979 changed the title set request->need_rounter to be false to prevent from infinite recursion request->need_rounter need to be set by set_need_routing(false) to prevent from infinite recursion Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cpd85 @zjzzjz1979