Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI module crash while trying to install hull auto-repair #6039

Open
Maks2103 opened this issue Feb 4, 2025 · 3 comments · May be fixed by #6062
Open

GUI module crash while trying to install hull auto-repair #6039

Maks2103 opened this issue Feb 4, 2025 · 3 comments · May be fixed by #6062

Comments

@Maks2103
Copy link
Contributor

Maks2103 commented Feb 4, 2025

Observed behaviour

Equipment market tab throws out an error when trying to install the hull auto-repair module

Image

Expected behaviour

UI tab working properly and without issues

Steps to reproduce

Open station comms, open equipment market, click on "Hull Auto-Repair System" in the module list

My pioneer version (and OS):
Pioneer version: 03.02.2025
OS: Windows 10 x64

My output.txt (required) and game save (optional, but recommended)
output.txt

@sturnclaw
Copy link
Member

This is most likely a bug with attempting to compare a numeric techlevel with the 'MILITARY' tech level. This will error every time you attempt to replace an installed item of MILITARY tech level.

@pghvlaans
Copy link
Contributor

@sturnclaw I also got a crash, with a slight twist: If there is nothing equipped in the selected slot, number formatting is attempted on literal "MILITARY."

Here's an output log for trying to buy something in an empty slot:

nothing-equipped.txt

And, for comparison, replacing existing equipment with MILITARY-level hardware:

had-equipped.txt

@pghvlaans
Copy link
Contributor

Looks like having Outfit:renderCompareRow in equipment_outfitter.lua interpret MILITARY as tech level 11 would fix the issue. I'll make a PR after testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants