Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent Formatting #6

Open
pithub opened this issue Sep 26, 2024 · 1 comment
Open

Inconsistent Formatting #6

pithub opened this issue Sep 26, 2024 · 1 comment

Comments

@pithub
Copy link
Owner

pithub commented Sep 26, 2024

During the porting process, I decided to keep the formatting of the Haskell code as close as possible and not use elm-format. The files formatted in this way start with

{- MANUALLY FORMATTED -}

The following files still use the old formatting and should be reformatted:

  • src/Compiler/AST/Canonical.elm
  • src/Compiler/AST/Source.elm
  • src/Compiler/AST/Utils/Binop.elm
  • src/Compiler/AST/Utils/Shader.elm
  • src/Compiler/AST/Utils/Type.elm
  • src/Compiler/Compile.elm
  • src/Compiler/Data/Index.elm
  • src/Compiler/Data/Name.elm
  • src/Compiler/Data/OneOrMore.elm
  • src/Compiler/Data/Utf8.elm
  • src/Compiler/Elm/Compiler/Imports.elm
  • src/Compiler/Elm/Float.elm
  • src/Compiler/Elm/Interface.elm
  • src/Compiler/Elm/Package.elm
  • src/Compiler/Elm/String.elm
  • src/Compiler/Elm/Version.elm
  • src/Compiler/Reporting/Annotation.elm
  • src/Compiler/Reporting/Doc.elm
  • src/Compiler/Reporting/Error.elm
  • src/Compiler/Reporting/Error/Canonicalize.elm
  • src/Compiler/Reporting/Error/Syntax.elm
  • src/Compiler/Reporting/Render/Code.elm
  • src/Compiler/Reporting/Render/Type.elm
  • src/Compiler/Reporting/Report.elm
  • src/Compiler/Reporting/Suggest.elm
  • src/Compiler/Reporting/Warning.elm

Other files that have been added to the original code of the Elm compiler should remain as they are: formatted with elm-format. These are mainly the files in src/Extra and src/Reactor and also

  • src/Global.elm
  • src/Main.elm
  • src/Terminal/Command.elm

Note: In the meantime, some files have been reformatted (see below). I have removed them from the list.

@pithub
Copy link
Owner Author

pithub commented Nov 7, 2024

As part of a larger commit series, some files have been reformatted:

  • src/Compiler/Canonicalize/Effects.elm
  • src/Compiler/Canonicalize/Environment.elm
  • src/Compiler/Canonicalize/Environment/Dups.elm
  • src/Compiler/Canonicalize/Environment/Foreign.elm
  • src/Compiler/Canonicalize/Environment/Local.elm
  • src/Compiler/Canonicalize/Expression.elm
  • src/Compiler/Canonicalize/Module.elm
  • src/Compiler/Canonicalize/Pattern.elm
  • src/Compiler/Canonicalize/Type.elm
  • src/Compiler/Elm/ModuleName.elm
  • src/Compiler/Reporting/Result.elm

See c779cc1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant