Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove/clean up any unnecessary files! #10

Closed
paperdigits opened this issue Jun 7, 2016 · 12 comments
Closed

Remove/clean up any unnecessary files! #10

paperdigits opened this issue Jun 7, 2016 · 12 comments

Comments

@paperdigits
Copy link
Contributor

@patdavid When you find a free minute, if you would please remove any files that you know can safely be removed, that'd be a big help in trying to consolidate the templates.

Without digging too deep, some suggested files to remove would be:

/templates/test.hbt
/templates/article.hbt.old
build-gitlab.js (I don't know what this does, but it is very similar to index.js)
@patdavid
Copy link
Member

patdavid commented Jun 7, 2016

Will do!

@patdavid
Copy link
Member

patdavid commented Jun 7, 2016

The build-gitlab.js was for building on the runners at gitlab (using .gitlab-ci.yml).
It's redundant here I think, and should be removed (along with .gitlab-ci.yml).

I'll start cleaning stuff out as I go through the files again. :)

@paperdigits
Copy link
Contributor Author

paperdigits commented Jun 7, 2016

Awesome, thanks!

I'd like to clean and combine to a point where:

  • there are a handful of meaningful templates
  • we are not repeating the head and meta elements all over the place
  • merge all style.css files into larger, more meaningful stylesheets
  • start using Sass if that's OK with you.

This things should make contributing to the site much easier for people who have never see the code and easier to maintain going forward.

On June 7, 2016 8:37:59 AM PDT, Pat David [email protected] wrote:

The build-gitlab.js was for building on the runners at gitlab (using
.gitlab-ci.yml).
It's redundant here I think, and should be removed (along with
.gitlab-ci.yml).

I'll start cleaning stuff out as I go through the files again. :)


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#10 (comment)

@paperdigits
Copy link
Contributor Author

paperdigits commented Jun 8, 2016

A reminder to myself to check the follwoing files located in the src directory:

./articles/hdr-photography-with-free-software-luminancehdr/index.css
./articles/digital-b-w-conversion-gimp/index.css
./articles/luminosity masking in darktable/index.css
./articles/basic-landscape-exposure-blending-with-gimp-and-g-mic/index.css
./articles/users-guide-to-high-bit-depth-gimp-2-9-2-part-1/index.css
./articles/basic-color-curves/index.css
./articles/skin retouching with wavelet decompose/index.css
./articles/freaky-details-calvin-hollywood/index.css
./articles/color-curves-matching/index.css
./articles/users-guide-to-high-bit-depth-gimp-2-9-2-part-2/index.css
./articles/a-q-a-with-photographer-riley-brandt/index.css
./articles/an open source portrait mairi/index.css
./articles/a blended panorama with photoflow/index.css
./blog/posts/2015-07-22 FOSS Photo Course Winners/index.css
./blog/posts/2015-06-05 Usertesting/index.css
./blog/posts/2015-07-13 darktable Windows/index.css
./blog/posts/2015-06-06 PhotoFlow Blended Panorama/index.css
./blog/posts/2015-07-13 Riley Brandt/index.css

Edit: Looks like the index.css files in blog are not loaded at all.

@patdavid
Copy link
Member

patdavid commented Jun 8, 2016

Those are for loading any local CSS that might be wanted for those particular posts. I suppose we could include the stylesheet in the markdown as well, but I started it this way to keep the markdown at least a little cleaner. :)

@paperdigits
Copy link
Contributor Author

Why not just write it in the main stylesheet?

On June 8, 2016 4:16:20 PM PDT, Pat David [email protected] wrote:

Those are for loading any local CSS that might be wanted for those
particular posts. I suppose we could include the stylesheet in the
markdown as well, but I started it this way to keep the markdown at
least a little cleaner. :)


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#10 (comment)

@patdavid
Copy link
Member

patdavid commented Jun 8, 2016

Usually because it may be one-off styles just for that post for some reason, and I didn't want to pollute other posts with them.

@paperdigits
Copy link
Contributor Author

Fair enough. Is that for articles, blog, or articles & blog?

On June 8, 2016 4:45:27 PM PDT, Pat David [email protected] wrote:

Usually because it may be one-off styles just for that post for some
reason, and I didn't want to pollute other posts with them.


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#10 (comment)

@patdavid
Copy link
Member

patdavid commented Jun 9, 2016

I think I had originally intended for it to be articles + blogposts. I realize they're hardly used... :)

@paperdigits
Copy link
Contributor Author

paperdigits commented Jun 9, 2016

We could do clever solution, like adding the value of the post's slug as a class to the main element wrapping the post's article, that way you could just add .some-blog-slug-value to the style sheet, then style away.

@patdavid
Copy link
Member

Does this now move to the #32 thread on refactoring the styles.scss?

@paperdigits
Copy link
Contributor Author

Yes indeed it does!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants