Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update HasRoles middleware to apply site admin role when applicable #10266

Closed
taslangraham opened this issue Jul 31, 2024 · 2 comments · Fixed by #10267
Closed

Update HasRoles middleware to apply site admin role when applicable #10266

taslangraham opened this issue Jul 31, 2024 · 2 comments · Fixed by #10267
Assignees
@taslangraham
Labels
Bug:2:Major A bug found in common paths that reduces functionality for a large number of users
Milestone
3.5 Internal

Comments

@taslangraham
Copy link
Contributor

taslangraham commented Jul 31, 2024 •
edited
Loading

Issue Description

See the following comments for context:
#10258 (comment)
#10258 (comment)

PR - #10267
@taslangraham taslangraham added the Accessibility Any issue that impacts assistive technology or users with visual or physical impairments. label Jul 31, 2024
@taslangraham taslangraham self-assigned this Jul 31, 2024
@taslangraham taslangraham removed the Accessibility Any issue that impacts assistive technology or users with visual or physical impairments. label Jul 31, 2024
taslangraham added a commit to taslangraham/pkp-lib that referenced this issue Jul 31, 2024
@taslangraham
pkp#10266 update HasRoles middleware to apply admin role for site wid…
6700082 
…e admins
@taslangraham taslangraham mentioned this issue Jul 31, 2024
Merged
@taslangraham
Copy link
Contributor Author

@asmecher @touhidurabir I've created a PR for this. Please take a look.
PR - #10267

@asmecher
Copy link
Member

asmecher commented Aug 1, 2024

Thanks, @taslangraham! @touhidurabir, could you take a first review?

@touhidurabir touhidurabir added this to the 3.5 Internal milestone Aug 1, 2024
taslangraham added a commit to taslangraham/pkp-lib that referenced this issue Aug 2, 2024
@taslangraham
pkp#10266 update HasRoles middleware to apply admin role for site wid…
4c6e77d 
…e admins
taslangraham added a commit to taslangraham/pkp-lib that referenced this issue Aug 2, 2024
@taslangraham
pkp#10266 update HasRoles middleware to apply admin role for site wid…
8f0583b 
…e admins
jonasraoni added a commit that referenced this issue Aug 3, 2024
@jonasraoni
Merge pull request #10267 from taslangraham/i10266-main

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
8da6ee0 
#10266 update HasRoles middleware to apply admin role for site wide admins
@jonasraoni jonasraoni added the Bug:2:Major A bug found in common paths that reduces functionality for a large number of users label Aug 3, 2024
@jonasraoni jonasraoni linked a pull request Aug 3, 2024 that will close this issue
pkp#10266 update HasRoles middleware to apply admin role for site wide admins #10267
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@taslangraham taslangraham

Labels
Bug:2:Major A bug found in common paths that reduces functionality for a large number of users
Projects
None yet
Milestone
3.5 Internal
Development

Successfully merging a pull request may close this issue.

pkp#10266 update HasRoles middleware to apply admin role for site wide admins taslangraham/pkp-lib
4 participants
@asmecher @jonasraoni @touhidurabir @taslangraham