Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesigned Workflow - Top controls (Activity Log, Library ,...) #10767

Open
jardakotesovec opened this issue Jan 3, 2025 · 4 comments
Open
Assignees
Milestone

Comments

@jardakotesovec
Copy link
Contributor

jardakotesovec commented Jan 3, 2025

Additional actions that appear in top right on workflow page. Its same as in 3.4. Providing some details when these show up.

Library (OJS,OMP,OPS)

  • always available for editors and authors

Activity Log (OJS,OMP,OPS)

  • activity log for editors - available for admin, journal manager, subeditors

View/Preview (OJS,OMP, OPS)

  • Preview is available for editors when its not published, but submission is copyediting or production stage
  • View is Available for editors when submission is published

Payment (OJS)

  • Available for editors when payments enabled and the publication fee set to > 0.

Enable it with following steps

  • Enable Manual Fee Payment plugin in Settings -> Website -> Installed Plugins.
  • Payments -> Payment types: set Article processing charge higher than 0
  • Settings -> Distribution -> Payments: check Enable, select Manual Fee Payment and Seems that the instructions also needs to be not empty

Worktype (OMP)

  • available for editors

Upload file (OJS,OMP)

  • Available for authors when revisions are requested/submitted.
  • Moved to the action area in 3.5 per design
  • Important to test also for omp internal stage to make sure its configured correctly and uploading file to correct file stage
@jardakotesovec jardakotesovec self-assigned this Jan 3, 2025
@jardakotesovec jardakotesovec changed the title Redesigned Workflow - top controls (Activity Log, Library ,...) Redesigned Workflow - Top controls (Activity Log, Library ,...) Jan 5, 2025
@jardakotesovec jardakotesovec added this to the 3.5.0 LTS milestone Jan 7, 2025
jardakotesovec added a commit to jardakotesovec/ui-library that referenced this issue Jan 8, 2025
jardakotesovec added a commit to jardakotesovec/ui-library that referenced this issue Jan 8, 2025
jardakotesovec added a commit to pkp/ui-library that referenced this issue Jan 8, 2025
@Tribunal33
Copy link

Tribunal33 commented Jan 10, 2025

Do you know what the expectations are for these buttons. Like Library, Activity log, View/Preview etc.. I guessed what they would do based on 3.4 but would be nice to know what they are expected to do.

@jardakotesovec slight difference between design and implementation for the "upload file" in OJS. Design button is "Upload Revisions" but currently says "Submit Revisions".

Image

jardakotesovec added a commit to pkp/ui-library that referenced this issue Jan 14, 2025
@jardakotesovec
Copy link
Contributor Author

jardakotesovec commented Jan 14, 2025

@Tribunal33 Good catch, I was checking with Devika whether we want different wording on the dashboard and workflow page for uploading revisions.. and she confirmed that we want, but I forgot to make the update. Its now updated on main branch.

Regarding what these buttons are supposed to do - I use 3.4 as reference. New code in 3.5 mostly handling whether they should be display and connecting them with modals.

@Tribunal33
Copy link

Thanks @jardakotesovec the original wording issue has been fixed.
I don't know if this is in scope, since the requirement for this ticket was moved to the action area but the quick actions in the submission list also has the Submit Revision wording but for consistency I think it should, also, be "Upload revisions" for authors that have revisions requested?

Image

@jardakotesovec
Copy link
Contributor Author

@Tribunal33 Editorial activity has its own ticket, but I confirmed with @Devika008 that for editorial activity she preferes Submit revisions wording.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants