-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make possible to open Vue.js modal from legacy grid #9932
Comments
Appreciate feedback from anyone. tagging @asmecher @jonasraoni @eirikhanssen @MrRob100 |
I can do a late review after I get back on track (11/05). I'm just curious if you didn't intend to tag @ewhanson instead of Eirik Hanssen 😁 |
@jardakotesovec On my setup this it needed |
@MrRob100 Cool, thanks for testing it out! I added PR for OJS with the updated minifiedScripts.tt |
* pkp/pkp-lib#9932 Introduce VueModal.php * pkp/pkp-lib#9932 Fixing legacyCloseHandler * Allow also for global modals to be picked up
Cleaned up and merged |
Describe the issue
Our goal is to write new interfaces using Vue.js components. One of the cases is new or re-build modals thats being triggered from the Legacy Grid. Example of such use case is in #9893 .
Solution
Proposing solution with new VueModal.php action as alternative to typical AjaxModal.php action, which makes possible to open Vue.js side modal, which is built as separate component from the grid action.
Steps for new modals would be
Its often important to communicate events back to grid to trigger reload if the action changes data. This can be achieved with following pattern:
PR (includes example that we don't want to merge unfinished, but its best to illustrate the functionality for review)
ojs: pkp/ojs#4266
pkp-lib: #9933
ui-library: pkp/ui-library#347
omp: pkp/omp#1568
ops: pkp/ops#681
The text was updated successfully, but these errors were encountered: