Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image serving on firefox broken? #140

Open
mixmix opened this issue Mar 5, 2023 · 4 comments
Open

image serving on firefox broken? #140

mixmix opened this issue Mar 5, 2023 · 4 comments

Comments

@mixmix
Copy link
Member

mixmix commented Mar 5, 2023

Here's another thing I found running through user flows... there's some client code bug for image display in Firefox. The images display in Brave/Chromium and Safari, just fine. Image shows Firefox on the left w/ broken images, Brave is on the left.

Image

(reported by @danlatorre #138 (comment))

@mixmix
Copy link
Member Author

mixmix commented Mar 5, 2023

@danlatorre I'm unable to reproduce

Loading your profile in firefox : https://planetary.name/profile/@GCSmjLHmFC8m9t0ouJ6cY4tzlQdIbBaQfI0Uifw5cZA=.ed25519

image


image

@mixmix
Copy link
Member Author

mixmix commented Mar 5, 2023

Can you post more about what version of Firefox, and the link to that profile.
In general always share the URL if you can, it makes testing + debugging way easier ❤️

Copy link
Contributor

rabble commented Mar 6, 2023

I'm pretty sure that images are broken inconsistently because it's planetary-graphql that's serving images and NOT nginx directly. This could also be why the graphql server sometimes just fails to respond for minutes at a time. under no condition should we be serving blobs from planetary-graphql. these need to be moved to be directly served from nginx.

@mplorentz
Copy link
Member

under no condition should we be serving blobs from planetary-graphql.

@rabble I don't understand why you say this. Can you explain why you think this is necessarily slow? In theory having nginx ask planetary-graphql should only add microseconds to the overall fetch time, which is insignificant to the milliseconds it takes to transfer a blob across the network to the browser. What am I missing?

@cooldracula was talking about migrating to a single nginx instance in the future rather than having each server run its own, which seems like a good idea to me. If we change to having nginx serve the blobs directly from disk then we still need to run nginx on every box.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants