-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A link in Task 3 on the lab is incorrect #205
Comments
@maithuvenkatesh would you like to send a PR to fix it? |
@maithuvenkatesh I have gone through the tutorial, it is working without any issues. @marcosnils we clone this issue. I am confident that I haven't seemed any issue |
I have had the same issue. The link in the .md file looks to be asking for port 80 but when I click on it in the tutorial it takes me to http://ip172-18-0-22-bsvbrg5im9m000andmog-8080.direct.labs.play-with-docker.com/ |
Hi! Sorry been away for quite a while it seems. @marcosnils I did looks into it and there wasn't an obvious fix. I need to delve into it a bit more. I think it's an issue with relative links. Thanks for confirming @HarryEMartland! Feel free to take a stab at fixing it. I won't be able to look into it in the next week. |
Would it be easier to change the commands to set the port to 8080? |
Encountered the same issue. Interesingly, I also noticed the corrected link does work in Chromium, but not in Firefox. Any Firefox user experienced the same issue? |
I traced the problem down to the JavaScript implementation in pwd.js, but I cannot find where pwd.js's repository is to make a pull request against. Anyone know where to find it? |
The repo is here https://github.com/play-with-docker/sdk
sent from mobile
Em sáb., 13 de abr. de 2024, 13:02, vollkorn1982 ***@***.***>
escreveu:
… I traced the problem down to the JavaScript implementation in pwd.js
***@***.***/dist/pwd.js>,
but I cannot find where pwd.js's repository is to make a pull request
against. Anyone know where to find it?
—
Reply to this email directly, view it on GitHub
<#205 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAMBLWWIFUQJB532TQXOEKLY5FJHVAVCNFSM4MFDXB2KU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TEMBVGM3DQNZVGI3Q>
.
You are receiving this because you were mentioned.Message ID:
***@***.***
com>
|
It's an upstream bug, follow progress in this issue: play-with-docker/sdk#56 |
Hello! I've observed this issue as well and have created a fix for it. The problem lies in the way the links are dynamically generated. I've submitted a pull request to address this (play-with-docker/sdk#57) |
The link provided in Step 2 of Task 3 of this lab in the section called "Test the new version" is incorrect.
This is the link's URL:
Seems like it should be port 80 not 8080
The text was updated successfully, but these errors were encountered: