Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A link in Task 3 on the lab is incorrect #205

Open
maithuvenkatesh opened this issue Apr 10, 2020 · 10 comments
Open

A link in Task 3 on the lab is incorrect #205

maithuvenkatesh opened this issue Apr 10, 2020 · 10 comments

Comments

@maithuvenkatesh
Copy link

The link provided in Step 2 of Task 3 of this lab in the section called "Test the new version" is incorrect.

This is the link's URL:

http://ip172-18-0-9-bq7qj75im9m000e1aaug-8080.direct.labs.play-with-docker.com/

Seems like it should be port 80 not 8080

http://ip172-18-0-9-bq7qj75im9m000e1aaug-80.direct.labs.play-with-docker.com/
@marcosnils
Copy link
Contributor

@maithuvenkatesh would you like to send a PR to fix it?

@jinnabaalu
Copy link

@maithuvenkatesh I have gone through the tutorial, it is working without any issues. @marcosnils we clone this issue. I am confident that I haven't seemed any issue

@HarryEMartland
Copy link

I have had the same issue. The link in the .md file looks to be asking for port 80 but when I click on it in the tutorial it takes me to http://ip172-18-0-22-bsvbrg5im9m000andmog-8080.direct.labs.play-with-docker.com/

https://github.com/play-with-docker/play-with-docker.github.io/blame/master/_posts/2016-10-25-beginner-linux.markdown#L394

@maithuvenkatesh
Copy link
Author

Hi! Sorry been away for quite a while it seems. @marcosnils I did looks into it and there wasn't an obvious fix. I need to delve into it a bit more. I think it's an issue with relative links. Thanks for confirming @HarryEMartland! Feel free to take a stab at fixing it. I won't be able to look into it in the next week.

@HarryEMartland
Copy link

Would it be easier to change the commands to set the port to 8080?

@vollkorn1982
Copy link

Encountered the same issue. Interesingly, I also noticed the corrected link does work in Chromium, but not in Firefox. Any Firefox user experienced the same issue?

@vollkorn1982
Copy link

I traced the problem down to the JavaScript implementation in pwd.js, but I cannot find where pwd.js's repository is to make a pull request against. Anyone know where to find it?

@marcosnils
Copy link
Contributor

marcosnils commented Apr 13, 2024 via email

@vollkorn1982
Copy link

It's an upstream bug, follow progress in this issue: play-with-docker/sdk#56

@FeSuert
Copy link

FeSuert commented Apr 29, 2024

Hello! I've observed this issue as well and have created a fix for it. The problem lies in the way the links are dynamically generated. I've submitted a pull request to address this (play-with-docker/sdk#57)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants