Update Template DSL to support placement prop #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/canary |
spentacular
approved these changes
Mar 7, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #196 +/- ##
==========================================
+ Coverage 67.10% 67.12% +0.02%
==========================================
Files 87 87
Lines 9123 9129 +6
Branches 1272 1274 +2
==========================================
+ Hits 6122 6128 +6
Misses 2976 2976
Partials 25 25 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
KetanReddy
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #190
Should be merged AFTER player-ui/player#614 since that introduces the
placementfunctionality in the core template logic.A separate ticket will be created to address inferring placement order based on JSX positioning.
Change Type (required)
Indicate the type of change your pull request is:
patchminormajorRelease Notes
Adds support to passing
placementto<Template />and added a test that confirms the prop gets passed down accordingly.📦 Published PR as canary version:
0.9.1--canary.196.4186Try this version out locally by upgrading relevant packages to 0.9.1--canary.196.4186