Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: migrate /components/theme/constants.ts to /pages/_app.tsx #370

Open
SgtPooki opened this issue May 12, 2023 · 1 comment
Open

fix: migrate /components/theme/constants.ts to /pages/_app.tsx #370

SgtPooki opened this issue May 12, 2023 · 1 comment

Comments

@SgtPooki
Copy link
Contributor

All of the variables/colors used in

export const SMALL_SCREEN_THRESHOLD = 720; // average mobile screen height in pixels.
const lightMode = {
header: {
background: {
color: '#27292C'
},
text: {
color: '#FFFFFF'
},
input: {
text: {
color: '#FFFFFF'
},
background: {
color: '#3C4651'
},
border: {
color: '#8D8D8D',
radius: '5px'
}
}
},
text: {
color: '#313239'
}
}
const darkMode = {
header: {
background: {
color: '#27292C'
},
text: {
color: '#FFFFFF'
},
input: {
text: {
color: '#FFFFFF'
},
background: {
color: '#3C4651'
},
border: {
color: '#8D8D8D',
radius: '5px'
}
}
},
text: {
color: '#D7D7D7'
}
}
export default {
light: lightMode,
dark: darkMode
}

should be migrated to

Starmap/pages/_app.tsx

Lines 12 to 43 in be39102

const theme = extendTheme({
semanticTokens: {
colors: {
inactive: {
// darkGray: '#D7D7D7',
default: '#D7D7D7',
},
inactiveAccent: {
// lightGray: '#EFEFEF',
default: '#EFEFEF',
},
progressGreen: {
// progressGreen: '#7DE087',
default: '#7DE087',
},
progressGreenAccent: {
// progressGreenAccent: 'rgba(125, 224, 135, 0.28)',
// default: 'rgba(125, 224, 135, 0.28)',
default: '#7de08747'
},
spotLightBlue: {
default: '#1FA5FF',
},
linkBlue: {
default: '#4987BD',
},
text: {
default: '#313239'
}
},
},
})

and used similar to how spotLightBlue is used. See https://github.com/search?q=repo%3Apln-planning-tools%2FStarmap%20spotLightBlue&type=code

@SgtPooki
Copy link
Contributor Author

related to #368

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant