bug: Uncaught (in promise) Error: Unsupported URL: https://github.com/issues/

[SgtPooki]

reported in slack

problem url: https://starmap.site/roadmap/github.com/filecoin-station/roadmap/issues/1

paramsFromUrl.ts:17 Uncaught (in promise) Error: Unsupported URL: https://github.com/issues/
    at s (paramsFromUrl.ts:17:11)
    at [...slug].tsx:147:45
    at s (runtime.js:45:40)
    at Generator._invoke (runtime.js:274:22)
    at forEach.e.<computed> [as next] (runtime.js:97:21)
    at n (asyncToGenerator.js:3:20)
    at s (asyncToGenerator.js:25:9)
    at asyncToGenerator.js:32:7
    at new Promise (<anonymous>)
    at asyncToGenerator.js:21:12

source:

• Starmap/lib/paramsFromUrl.ts

  Line 17 in be39102

  throw new Error(`Unsupported URL: ${urlString}`);

• Starmap/pages/roadmap/[...slug].tsx

  Line 147 in be39102

  const { issue_number, owner, repo } = paramsFromUrl(typedPendingChild.html_url.value)

[SgtPooki]

I attempted to load this URL, got a successfully rendered roadmap, and then refreshed and it succeeded again.

I removed my “debug” item in localStorage and reloaded, and got the same error as reported; investigating now.

[SgtPooki]

it seems like the children of CheckerNetwork/roadmap#12 are not being recognized properly.

[SgtPooki]

The children parsing logic was failing on parsing a linePiece that was equal to ### due to:

Starmap/lib/getValidUrlFromInput.ts

Lines 1 to 22 in be39102

	export function getValidUrlFromInput(urlString: string): URL {
	if (urlString.includes('#')) {
	urlString = urlString.replace('#', '/issues/')
	} else if (!urlString.includes('issues')) {
	throw new Error('Unsupported URL string. URLs should be formatted like a github issue')
	}
	/**
	* Cannot construct a URL from the given string.
	*/
	if (urlString.includes('http')) {
	try {
	return new URL(urlString)
	} catch {}
	}
	if (urlString.includes('github.com')) {
	try {
	return new URL(`https://${urlString}`)
	} catch {}
	}
	return new URL(urlString, 'https://github.com')
	};

returning https://github.com/issues/## when called by

Starmap/lib/parser.ts

Line 94 in be39102

getValidUrlFromInput(linePiece.replace(/pull/g, 'issues'))