From 1f3ed995aecdfb4740334fd4ba45fc6589af0b25 Mon Sep 17 00:00:00 2001 From: 1letter <1letter@gmx.de> Date: Fri, 14 Feb 2025 12:55:33 +0100 Subject: [PATCH 1/5] fix robottests for contentbrowser --- .../CMFPlone/tests/robot/test_contentbrowser.robot | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/Products/CMFPlone/tests/robot/test_contentbrowser.robot b/Products/CMFPlone/tests/robot/test_contentbrowser.robot index 10c712b678..68f9dd84fd 100644 --- a/Products/CMFPlone/tests/robot/test_contentbrowser.robot +++ b/Products/CMFPlone/tests/robot/test_contentbrowser.robot @@ -136,8 +136,8 @@ I select a related item image via contentbrowser Click item in contenbrowser column 4 3 # Click second element in fifth column, that is the "Image2" Object Click item in contenbrowser column 5 2 - # Click the select Button in the Toolbar of column 6 - Click //div[contains(@class, "content-browser-wrapper")]//div[contains(@class, "levelColumns")]/div[6]/div[contains(@class, "levelToolbar")]/button + # Click the select Button in the Toolbar of column 6 + Click //div[contains(@class, "content-browser-wrapper")]//div[contains(@class, "levelColumns")]/div[6]/div[contains(@class, "levelToolbar")]/div[contains(@class,"selectLevel")]/button I select two related item images via contentbrowser @@ -181,7 +181,7 @@ I set an internal link via contentbrowser ... all_elements=False Click tiny button and open contentbrowser Insert/edit link Click item in contenbrowser column 1 3 - Click //div[contains(@class, "content-browser-wrapper")]//div[contains(@class, "levelColumns")]/div[contains(@class, "preview")]/div[contains(@class, "levelToolbar")]/button + Click //div[contains(@class, "content-browser-wrapper")]//div[contains(@class, "levelColumns")]/div[contains(@class, "preview")]/div[contains(@class, "levelToolbar")]/div[contains(@class,"selectLevel")]/button Click //div[contains(@class, 'modal-footer')]//input[contains(@name, 'insert')] I set an image via contentbrowser @@ -191,7 +191,7 @@ I set an image via contentbrowser Click item in contenbrowser column 1 3 Click item in contenbrowser column 2 1 Click item in contenbrowser column 3 1 - Click //div[contains(@class, "content-browser-wrapper")]//div[contains(@class, "levelColumns")]/div[contains(@class, "preview")]/div[contains(@class, "levelToolbar")]/button + Click //div[contains(@class, "content-browser-wrapper")]//div[contains(@class, "levelColumns")]/div[contains(@class, "preview")]/div[contains(@class, "levelToolbar")]/div[contains(@class,"selectLevel")]/button Click //div[contains(@class, 'modal-footer')]//input[contains(@name, 'insert')] I upload an image via contentbrowser @@ -204,7 +204,7 @@ I upload an image via contentbrowser Upload File By Selector //div[contains(@class,"pat-upload")]//input[@class="dz-hidden-input"] ${PATH_TO_TEST_FILES}/plone-logo.png Click //div[contains(@class,"pat-upload")]//button[contains(@class,"upload-all")] Click item in contenbrowser column 3 3 - Click //div[contains(@class, "content-browser-wrapper")]//div[contains(@class, "levelColumns")]/div[contains(@class, "preview")]/div[contains(@class, "levelToolbar")]/button + Click //div[contains(@class, "content-browser-wrapper")]//div[contains(@class, "levelColumns")]/div[contains(@class, "preview")]/div[contains(@class, "levelToolbar")]/div[contains(@class,"selectLevel")]/button Click //div[contains(@class, 'modal-footer')]//input[contains(@name, 'insert')] I search and select an image via contentbrowser @@ -219,8 +219,8 @@ I search and select an image via contentbrowser Type Text //div[contains(@class, "content-browser-wrapper")]//div[contains(@class, "toolBar")]//input[contains(@name,"filter")] Anot # here we need a timeout, because the search filter is not so fast like the testbrowser, it looks like a asynch operation Sleep 1 - Click item in contenbrowser column 5 1 - Click //div[contains(@class, "content-browser-wrapper")]//div[contains(@class, "levelColumns")]/div[contains(@class, "preview")]/div[contains(@class, "levelToolbar")]/button + Click item in contenbrowser column 1 1 + Click //div[contains(@class, "content-browser-wrapper")]//div[contains(@class, "levelColumns")]/div[contains(@class, "preview")]/div[contains(@class, "levelToolbar")]/div[contains(@class,"selectLevel")]/button Click //div[contains(@class, 'modal-footer')]//input[contains(@name, 'insert')] I save the document From 28bf2468745faa38b52ab7e4a0b81c712523f009 Mon Sep 17 00:00:00 2001 From: 1letter <1letter@gmx.de> Date: Fri, 14 Feb 2025 13:27:39 +0100 Subject: [PATCH 2/5] add news entry --- news/4112.testing | 2 ++ 1 file changed, 2 insertions(+) create mode 100644 news/4112.testing diff --git a/news/4112.testing b/news/4112.testing new file mode 100644 index 0000000000..c8478c73dc --- /dev/null +++ b/news/4112.testing @@ -0,0 +1,2 @@ +fix robottests for contentbrowser improvements +[1letter] From 25aec8291830014f731cf128b5d6adb67b5e7255 Mon Sep 17 00:00:00 2001 From: 1letter <1letter@gmx.de> Date: Fri, 14 Feb 2025 14:34:52 +0100 Subject: [PATCH 3/5] fix robottest linkintegrity --- Products/CMFPlone/tests/robot/test_linkintegrity.robot | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Products/CMFPlone/tests/robot/test_linkintegrity.robot b/Products/CMFPlone/tests/robot/test_linkintegrity.robot index a476af3476..bb129a63b3 100644 --- a/Products/CMFPlone/tests/robot/test_linkintegrity.robot +++ b/Products/CMFPlone/tests/robot/test_linkintegrity.robot @@ -62,7 +62,7 @@ I add a link in rich text Click //button[@aria-label="Insert/edit link"] Click //div[contains(@class,"linkModal")]//div[contains(@class,"content-browser-selected-items-wrapper")]//a[contains(@class,"btn-primary")] Click item in contenbrowser column 1 3 - Click //div[contains(@class, "content-browser-wrapper")]//div[contains(@class, "levelColumns")]/div[contains(@class, "preview")]/div[contains(@class, "levelToolbar")]//button[contains(@class, "btn-primary")] + Click //div[contains(@class, "content-browser-wrapper")]//div[contains(@class, "levelColumns")]/div[contains(@class, "preview")]/div[contains(@class, "levelToolbar")]//button Click //div[contains(@class,"modal-footer")]//input[@name="insert"] Click //button[@name="form.buttons.save"] Get Text //body contains Changes saved From d14041c0a7cd65fa411bdd223658bcf6dfd14b00 Mon Sep 17 00:00:00 2001 From: 1letter <1letter@gmx.de> Date: Fri, 14 Feb 2025 15:05:06 +0100 Subject: [PATCH 4/5] fix robottest querystring --- Products/CMFPlone/tests/robot/test_querystring.robot | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Products/CMFPlone/tests/robot/test_querystring.robot b/Products/CMFPlone/tests/robot/test_querystring.robot index 12e75d808b..b0456ba911 100644 --- a/Products/CMFPlone/tests/robot/test_querystring.robot +++ b/Products/CMFPlone/tests/robot/test_querystring.robot @@ -355,7 +355,7 @@ I search in ${NAME} subfolder in the contentbrowser widget mark results Click //div[@class="querystring-criteria-value"]//div[contains(@class, "content-browser-selected-items-wrapper")]//a[contains(@class, "btn-primary")] Click //div[contains(@class, "content-browser-wrapper")]//div[contains(@class, "levelColumn")]//div[contains(@class, "item-title")][text()[contains(.,'${NAME}')]] - Click //div[contains(@class, "content-browser-wrapper")]//div[contains(@class, "levelColumns")]/div[3]/div[contains(@class, "levelToolbar")]/button + Click //div[contains(@class, "content-browser-wrapper")]//div[contains(@class, "levelColumns")]//div[contains(@class, "levelToolbar")]//button[@title="select B"] I open the select box titled operator From 64f2a9fe1c086a244b6121bef8653d5e8554be33 Mon Sep 17 00:00:00 2001 From: 1letter <1letter@gmx.de> Date: Fri, 14 Feb 2025 17:33:27 +0100 Subject: [PATCH 5/5] fix robottest edit --- Products/CMFPlone/tests/robot/test_edit.robot | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Products/CMFPlone/tests/robot/test_edit.robot b/Products/CMFPlone/tests/robot/test_edit.robot index 928778ee61..3e1c01e251 100644 --- a/Products/CMFPlone/tests/robot/test_edit.robot +++ b/Products/CMFPlone/tests/robot/test_edit.robot @@ -114,7 +114,7 @@ I select a related item # Click first element in first column Click item in contenbrowser column 1 1 # Click the select Button in the Toolbar of column 2 - Click //div[contains(@class, "content-browser-wrapper")]//div[contains(@class, "levelColumns")]/div[2]/div[contains(@class, "levelToolbar")]//button[contains(@class, "btn-primary")] + Click //div[contains(@class, "content-browser-wrapper")]//div[contains(@class, "levelColumns")]/div[2]/div[contains(@class, "levelToolbar")]//button[contains(@class, "btn-outline-primary")] I select a linked item # Click the select button @@ -123,7 +123,7 @@ I select a linked item Click item in contenbrowser column 1 1 # Click the select Button in the Toolbar of column 2 # This selects the "test-folder" - Click //div[contains(@class, "content-browser-wrapper")]//div[contains(@class, "levelColumns")]/div[2]/div[contains(@class, "levelToolbar")]//button[contains(@class, "btn-primary")] + Click //div[contains(@class, "content-browser-wrapper")]//div[contains(@class, "levelColumns")]/div[2]/div[contains(@class, "levelToolbar")]//button[contains(@class, "btn-outline-primary")] I save the page Click //button[@name="form.buttons.save"]