Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Dash 3.0rc1, component typing id as dict and datetime for Date pickers #3141

Open
tlauli opened this issue Jan 29, 2025 · 0 comments
Open

[BUG] Dash 3.0rc1, component typing id as dict and datetime for Date pickers #3141

tlauli opened this issue Jan 29, 2025 · 0 comments
Assignees
@T4rk1n
Labels
dash-3.0 Going in dash-3.0 release. P1 needed for current cycle

Comments

@tlauli
Copy link

tlauli commented Jan 29, 2025

Hi, I tried to update to dash 3.0rc1, and what I noticed is that some typehints are too strict. What I found:

  • ids are typed as typing.Optional[str], omitting dict ids
  • dates in datepickers are typed as typing.Optional[str], but we use datetime.dates without problem, not sure if dates working is intended or just a coincidence though
    There are possibly others, this is what I found in our codebase.
@T4rk1n T4rk1n self-assigned this Jan 29, 2025
@T4rk1n T4rk1n added dash-3.0 Going in dash-3.0 release. P1 needed for current cycle labels Jan 29, 2025
@T4rk1n T4rk1n mentioned this issue Jan 29, 2025
Merged
@T4rk1n T4rk1n changed the title [BUG] Dash 3.0rc1 too strict typehints [BUG] Dash 3.0rc1, component typing id as dict and datetime for Date pickers Feb 6, 2025
@T4rk1n T4rk1n mentioned this issue Feb 6, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@T4rk1n T4rk1n

Labels
dash-3.0 Going in dash-3.0 release. P1 needed for current cycle
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@T4rk1n @tlauli