Bug: opening an abstraction marks it as editted

[dromer]

When opening an abstraction it immediately is marked as edited even though we didn't change anything.
Trying to close it will ask us to save the changes.

I thought we had this issue before, but it was fixed (can't find it though).
So could be a regression somewhere.

[timothyschoen]

Ah, gonna fix that!

Btw: changed your mind about syntax highlighting?

[dromer]

@timothyschoen I have had to reset the config several times and I work on 3-4 different machines so haven't set my own config yet.

Still not 100% convinced this looks good though :P

[dromer]

Hmm, I can't reproduce the issue on another machine. Both are running the latest nightly ..

[dromer]

Can't reproduce it atm. Will re-open if it re-appears ..

[timothyschoen]

Seems like @porres is running into this issue as well, so worth investigating

[dromer]

Hmm, with latest develop on another machine it's now also giving this issue (which I couldn't reproduce two days ago ..)

So yeah definitely something strange and inconsistent going on 🤔

[dromer]

This still happens regularly on latest nightly, btw.

I've still not detected a straightforward pattern that allows it to be easily reproduced :#

[tmhglnd]

I encounter this as well. Also don't see any pattern why.

[dromer]

It sometimes also happens for subpatches, which is odd since changes would go to the main patch.

From what I can tell only the sub-patch is marked as edited and when closing it we get a warning.

[timothyschoen]

I think I've found a pattern: it asks to save an abstraction if the parent patch if was opened from is marked dirty. That's at least one case I can reproduce some of the time

Edit: seems like this worked yesterday, but it doesn't happen anymore now...

[dromer]

Except it also happens when the parent patch hasn't been modified at all.

It's definitely very hard to reproduce, as the same patch may give this behavior one time, but not the next session.

[timothyschoen]

I did another fix, hope it doesn't happen anymore now

[dromer]

I'll update my local builds and play around .. we'll see what happens :P