Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

broken demos (errors in console) #18

Closed
1 of 2 tasks
abernier opened this issue Jul 25, 2024 · 5 comments
Closed
1 of 2 tasks

broken demos (errors in console) #18

abernier opened this issue Jul 25, 2024 · 5 comments

Comments

@abernier
Copy link
Member

abernier commented Jul 25, 2024

they build BUT they are errors in console

TODO: list them here

@rndexe
Copy link
Contributor

rndexe commented Jul 30, 2024

CSG House demo:

  1. Change RandomLight intensity to Math.PI and adjust alphaTest in Accumulative Shadows to to make the shadowcatcher plane invisible.
<AccumulativeShadows frames={100} alphaTest={0.7} opacity={0.75} scale={30} position={[0, -1.5, 0]}>
  <RandomizedLight amount={8} radius={2.5} ambient={0.5} intensity={Math.PI} position={direction} bias={0.001} />
</AccumulativeShadows>
  1. Switch envMapIntensity from meshStandardMaterial to environmentIntensity in EnvironmentImpl
    <EnvironmentImpl preset="city" environmentIntensity={0.25} />

@abernier
Copy link
Member Author

abernier commented Jul 30, 2024

@rndexe could you submit a pr for this fix? You can test with:

$ npm run -w demos/csg-house dev

@rndexe
Copy link
Contributor

rndexe commented Jul 30, 2024

Sure. I might try to fix a few other demos as well. Do you think I should submit PRs individually or combined?

@abernier
Copy link
Member Author

would say individually:) ty

@abernier abernier changed the title broken demos broken demos (don't build) Aug 1, 2024
@abernier abernier changed the title broken demos (don't build) broken demos (errors in console) Aug 1, 2024
@abernier abernier closed this as completed Aug 1, 2024
@abernier
Copy link
Member Author

abernier commented Aug 1, 2024

superseded by #38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants