Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid layout settings as parameters #1852

Open
IRRDC opened this issue Jul 11, 2024 · 1 comment
Open

Grid layout settings as parameters #1852

IRRDC opened this issue Jul 11, 2024 · 1 comment
Labels
help wanted type:enhancement New feature or enhancement of existing capability

Comments

@IRRDC
Copy link
Contributor

IRRDC commented Jul 11, 2024

Category

[X] Enhancement

[ ] Bug

[ ] Question

Version

Please specify what version of the library you are using: [3.18.1]

Expected / Desired Behavior / Question

At the moment these parameters that define the grid layout are stored in GridLayout.module.scss: padding, minWidth, maxWidth, compactThreshold, rowsPerPage. It would be very useful to have them be part of IGridLayoutProps to be able to modify the layout when needed.

@michaelmaillot michaelmaillot added help wanted type:enhancement New feature or enhancement of existing capability labels Jan 29, 2025
@michaelmaillot
Copy link
Collaborator

michaelmaillot commented Jan 29, 2025

Hi @IRRDC,

Nice idea! From what I quickly overviewed, I think we should keep default values (if no prop specified) as designed in the scss file.

Would you like to give a try?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted type:enhancement New feature or enhancement of existing capability
Projects
None yet
Development

No branches or pull requests

2 participants