Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DynamicField control missing documentation #1938

Open
Rothrock42 opened this issue Jan 21, 2025 · 4 comments
Open

DynamicField control missing documentation #1938

Rothrock42 opened this issue Jan 21, 2025 · 4 comments
Labels

Comments

@Rothrock42
Copy link

Rothrock42 commented Jan 21, 2025

Using the dynamic forms for the first time. We had a need to do a few simple overrides. It took us awhile to notice that there is a control that can be used. Is there a reason it isn't included in the documention?

Is there some reason not to use DynamicField directly? For example, we have a field were we are setting the default value and disabling it, otherwise it should look just like every other field.

<DynamicField {...props} defaultValue={fancyValue} disabled={true} />

Copy link

Thank you for submitting your first issue to this project.

@michaelmaillot
Copy link
Collaborator

Hi @Rothrock42,

Thanks for pointing that out. You're right, we're definitely missing example about field overrides in the DynamicForm doc page.

This could be improved. If you'd like to submit something, let me know so that I can assign this to you.

Regarding exposure of DynamicField component, I don't have the background that explains why is it internal. @AJIXuMuK or @joelfmrodrigues may know somehow?

@AJIXuMuK
Copy link
Collaborator

AJIXuMuK commented Feb 8, 2025

The idea is (was) that DynamicForm renders the fields. So a developer should not care of DynamicField component as it is used internally.
However, I see the scenario when it can be used in field overrides

@michaelmaillot
Copy link
Collaborator

Thanks for your answer @AJIXuMuK, maybe we could declare an issue regarding exposure of DynamicField, that could be documented through another example of field override?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants