From 4a7dc1d7a4d76ad25f7d0fea4a27ae6841b0b7ba Mon Sep 17 00:00:00 2001 From: Josh Klopfenstein Date: Thu, 19 Dec 2024 08:04:04 -0600 Subject: [PATCH] address review comments --- e2e/e2e.go | 1 + e2e/stack_test.go | 1 - engine/engine.go | 1 - opdevnet/opdevnet_test.go | 2 -- 4 files changed, 1 insertion(+), 4 deletions(-) diff --git a/e2e/e2e.go b/e2e/e2e.go index ab489c60..375b7e7b 100644 --- a/e2e/e2e.go +++ b/e2e/e2e.go @@ -76,6 +76,7 @@ func Run( "--monomer.sequencer", )) // Use a headless dlv instance to debug the testapp. + // Connect using `dlv connect :2345`. //nolint:gocritic // commentedOutCode /* appCmd := setupCmd(exec.CommandContext(ctx, diff --git a/e2e/stack_test.go b/e2e/stack_test.go index 3b5ae101..3209d09f 100644 --- a/e2e/stack_test.go +++ b/e2e/stack_test.go @@ -245,7 +245,6 @@ func ethRollupFlow(t *testing.T, stack *e2e.StackConfig) { // create a withdrawal tx to withdraw the deposited amount from L2 back to L1 withdrawalTx := e2e.NewWithdrawalTx(0, common.Address(userCosmosETHAddress), userETHAddress, withdrawalAmount, new(big.Int).SetUint64(params.TxGas)) - t.Logf("FROM TEST: %s", userCosmosAddr) baseAccount := queryAccount(t, stack, userCosmosAddr) l2ChainID, err := stack.MonomerClient.ChainID(stack.Ctx) require.NoError(t, err) diff --git a/engine/engine.go b/engine/engine.go index 7aaee8e8..58b53a83 100644 --- a/engine/engine.go +++ b/engine/engine.go @@ -58,7 +58,6 @@ func (e *EngineAPI) ForkchoiceUpdatedV1( fcs eth.ForkchoiceState, //nolint:gocritic pa *eth.PayloadAttributes, ) (*eth.ForkchoiceUpdatedResult, error) { - // TODO should this be called after Ecotone? return e.ForkchoiceUpdatedV3(ctx, fcs, pa) } diff --git a/opdevnet/opdevnet_test.go b/opdevnet/opdevnet_test.go index 520e216d..cd016ca5 100644 --- a/opdevnet/opdevnet_test.go +++ b/opdevnet/opdevnet_test.go @@ -124,8 +124,6 @@ func TestOPDevnet(t *testing.T) { l2SlotDuration := time.Duration(opConfig.Node.Rollup.BlockTime) * time.Second - t.Log("L1 and OP are setup") - // Confirm safe blocks are incrementing to ensure the batcher is posting blocks to the DA layer. for l2Instance.Backend.BlockChain().CurrentSafeBlock().Number.Uint64() < 3 { time.Sleep(l2SlotDuration)