Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More space in Plan Builder #184

Open
vogti opened this issue Feb 1, 2020 · 28 comments · May be fixed by polypheny/Polypheny-UI#89
Open

More space in Plan Builder #184

vogti opened this issue Feb 1, 2020 · 28 comments · May be fixed by polypheny/Polypheny-UI#89
Labels
A-ui Area: UI C-enhancement Category: An issue proposing an enhancement E-good-first-issue P-low Priority: Low

Comments

@vogti
Copy link
Member

vogti commented Feb 1, 2020

Increase the available space in the Plan Builder. Allow horizontal and vertical scrolling if necessary. It might make sense to move the query results to an independent page.

@vogti vogti added C-enhancement Category: An issue proposing an enhancement A-ui Area: UI E-easy P-low Priority: Low labels Feb 1, 2020
@parassharm80
Copy link

parassharm80 commented Mar 26, 2021

Hi, I am Paras Sharma. I would like to participate in GSOC 2021 and contribute to this project. I want to start this by solving this issue.

@vogti
Copy link
Member Author

vogti commented Mar 26, 2021

Hi @parassharm80, welcome to Polypheny! I have assigned the issue to you. Please follow this on how to set up Polypheny-DB in your favorite IDE and this guide on how to manually build Polypheny-UI. Feel free to ask here or open a thread in the discussions forum if you have any questions or experience any issues with setup.

@vogti
Copy link
Member Author

vogti commented Apr 2, 2021

Hi @parassharm80, is everything working fine? If you have any issues or need help getting started, please do not hesitate to either ask here or open a thread in the discussion forum.

@Pawanupadhyay10
Copy link

Hi @vogti , This #184 (inactive) issue and i will prefer to contribute in it if @parassharm80 may don't have any issue regarding it.

@vogti
Copy link
Member Author

vogti commented Apr 9, 2021

@parassharm80 Are you still working on this issue?

@parassharm80 parassharm80 removed their assignment Apr 9, 2021
@parassharm80
Copy link

Hi, I am stuck on other projects. You can assign this to someone else

@vogti
Copy link
Member Author

vogti commented Apr 9, 2021

Thanks, @parassharm80, for the feedback. @Pawanupadhyay10 I have assigned the issue to you.

@Pawanupadhyay10
Copy link

Hi @vogti can you make this task more easy to understand via providing a vedio .

@vogti
Copy link
Member Author

vogti commented Apr 11, 2021

Since this is an enhancement and not a bug, it is not really possible to create a video. But I can of course help you to understand the idea of this issue. Which part is unclear for you?

@Pawanupadhyay10
Copy link

Pawanupadhyay10 commented Apr 12, 2021

image

Hi, @vogti vertical scrolling is already there ,and about spacing ,in which part/area I need to add more space .This is not clear to me,Kindly guide me so that ,issue can be completed soon.

@vogti
Copy link
Member Author

vogti commented Apr 12, 2021

Hi @Pawanupadhyay10 this issue is about the plan builder (like #255).

@Pawanupadhyay10
Copy link

Hey @vogti please ,see image above I shared, where I need clarity.

@vogti
Copy link
Member Author

vogti commented Apr 12, 2021

The space is limited by the window size. There is no horizontal scrolling and vertical scrolling is limited.

@Pawanupadhyay10
Copy link

image

HI,@vogti I have added the horizontal scroll bar and more space in plan builder please see the image attached.

@Pawanupadhyay10
Copy link

Hi,@vogti, please have look on My PR.Thanks.

@vogti
Copy link
Member Author

vogti commented Apr 17, 2021

Hi @Pawanupadhyay10, while your solution does indeed increase the available space on smaller screens, it limits the space on larger screens. So that makes things even worse.

To fix this problem, a more sophisticated solution is required. The idea would be to have an infinite space.

@Pawanupadhyay10
Copy link

ok,@vogti, but as issue is closed ,how can I improve it.

@Pawanupadhyay10
Copy link

Can ,i start with a new issue.

@vogti
Copy link
Member Author

vogti commented Apr 17, 2021

I have only closed the PR, not the issue. You can simply open a new pull request with the improved solution for this problem.

@Pawanupadhyay10
Copy link

ok,Thanks.

@vogti
Copy link
Member Author

vogti commented Apr 17, 2021

Of course, shall I unassign you from this issue?

@Pawanupadhyay10
Copy link

I am thinking for better solution ,but if you like to assign me new issue, I have no problem then.

@vogti
Copy link
Member Author

vogti commented Apr 17, 2021

Oh, then I misunderstood you. I thought you ask whether you can work on a new issue (instead of this one).

@Pawanupadhyay10
Copy link

Hi,@vogti , please have a look now , for better solution in my PR.

@Pawanupadhyay10
Copy link

hi.@vogti have a look on the PR.

@vogti
Copy link
Member Author

vogti commented Apr 25, 2021

Hi @Pawanupadhyay10, thanks for the pull request. Unfortunately, this is still not a proper solution. While it no longer limits the available space on larger screens, the available space is still static. Since the run button is only accessible by scrolling, your change makes the plan builder difficult to use. As I pointed out in one of my previous comments, fixing this issue requires a more sophisticated approach. It might be better if you first think of an approach on how to address this. We can then discuss this.

@Pawanupadhyay10
Copy link

Okay@vogti.

@EslamAsHhraf
Copy link

@vogti Hi, can you assign me this issue, I believe i can solve it

@EslamAsHhraf EslamAsHhraf linked a pull request Apr 1, 2024 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ui Area: UI C-enhancement Category: An issue proposing an enhancement E-good-first-issue P-low Priority: Low
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants