Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement GET Request Handling for Ismp Parachain Inherent Provider#213 #378

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Implement GET Request Handling for Ismp Parachain Inherent Provider#213 #378

wants to merge 2 commits into from

Conversation

Nathy-bajo
Copy link

Attempts to resolve #213

  • Introduced a new field get_responses in the ConsensusInherentProvider struct to store responses to GET requests.
  • Modified the create method to fetch GET requests from the runtime API and store responses in the get_responses field.
  • Added a new method get_relay_chain_requests to the IsmpParachainApi trait to fetch relay chain GET requests.

@Nathy-bajo
Copy link
Author

Please review @seunlanlege @Wizdave97

@seunlanlege
Copy link
Member

Please review @seunlanlege @Wizdave97

This is unfortunately wrong. The right approach would be to fetch all requests emitted in the parent block and look for GetRequests to the relay chain there. Not sure why you introduce a new runtime api but not implement it, did you try compiling the entire project at all?

@Nathy-bajo
Copy link
Author

Nathy-bajo commented Feb 7, 2025 •
edited
Loading

Please review @seunlanlege @Wizdave97

This is unfortunately wrong. The right approach would be to fetch all requests emitted in the parent block and look for GetRequests to the relay chain there.

Yeah I thought so too. I was originally going to send as a draft to get your feedback.

Not sure why you introduce a new runtime api but not implement it, did you try compiling the entire project at all?

I was having issues compiling the entire project but after spending more time with the hyperbridge doc I think I'm on the right track.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ismp Parachain inherent relay chain Get request handling.
2 participants
@Nathy-bajo @seunlanlege