Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sub menus #2271

Open
ValWood opened this issue Nov 11, 2024 · 27 comments
Open

sub menus #2271

ValWood opened this issue Nov 11, 2024 · 27 comments
Assignees

Comments

@ValWood
Copy link
Member

ValWood commented Nov 11, 2024

When the sub-menus are opened it's a bit difficult to notice which are sub menus.

If these could be coloured slightly differently it might help?

Screenshot 2024-11-09 at 10 42 25
@kimrutherford

This comment was marked as outdated.

@ValWood
Copy link
Member Author

ValWood commented Nov 12, 2024

not necessarily more noticeable , but might be better if they were better differentiated.

@PCarme
Copy link
Contributor

PCarme commented Nov 12, 2024

Would it be possible (and interesting) to have a 3-levels menu, kind of like this :
384862492-616b378b-0280-42f2-ba9c-ca4177744f62-2

kimrutherford added a commit that referenced this issue Nov 14, 2024
@kimrutherford
Copy link
Member

but might be better if they were better differentiated.

We could indent them more?

@kimrutherford
Copy link
Member

kimrutherford commented Nov 14, 2024

For comparison, we have a sub-nested menu in the documentation: https://www.pombase.org/downloads

@ValWood

This comment was marked as outdated.

@ValWood

This comment was marked as outdated.

@ValWood ValWood removed the discuss label Nov 26, 2024
@kimrutherford
Copy link
Member

Link this ticket to the other suggestion

#1940 (comment)

I think the plan is to highlight the menu item(s) as they scroll into view.

@kimrutherford

This comment was marked as resolved.

@kimrutherford
Copy link
Member

There are many bugs still though

There are fewer bugs now so I've released the changes.

For now the highlighting is quite subtle but it's easy to change. Also all the sections that are on screen are highlighted in the menu, not just the first. That was easier to implement so I thought we could give that a go first.

Let's chat about it on the call.

image

@kimrutherford
Copy link
Member

There are fewer bugs now so I've released the changes.

It's only implemented for gene pages so far. I'll add it to the other pages (publications, terms, genotypes, alleles) once we've had a chat about it.

@ValWood
Copy link
Member Author

ValWood commented Dec 12, 2024

I just noticed this, nice.
I think the highlighting could be stronger.
@PCarme what do you think? (compare to SGD)

@PCarme
Copy link
Contributor

PCarme commented Dec 12, 2024

I think that's pretty neat too !
The highlighting seems clear enough with the darker edge on the right, maybe it could be stronger, but I don't think it needs to be as obvious as on SGD.
I noticed that sometimes a section is highlighted even though it doesn't appear on screen (like Modification in the image below)
image

@kimrutherford
Copy link
Member

Hi Pascal. Which browser is that?

@kimrutherford
Copy link
Member

I think the highlighting could be stronger.

I thought I'd start with quite subtle highlighting and then we can make it stronger if needed. It's a very easy thing to experiment with live on a call sometime to try a few options.

@PCarme
Copy link
Contributor

PCarme commented Dec 13, 2024

Hi Pascal. Which browser is that?

Hi Kim, I'm using Safari.

@kimrutherford
Copy link
Member

Hi Kim, I'm using Safari.

OK, thanks. That's the one browser I can't test.

Firefox and Chrome don't seem to have the same problem.

In my desktop version I've made the sensitivity a little bit lower. Could you try my desktop version and see if you have the same issue?: https://desktop.kmr.nz/gene/SPAC20G8.05c

Thanks!

@PCarme
Copy link
Contributor

PCarme commented Dec 13, 2024

In my desktop version I've made the sensitivity a little bit lower. Could you try my desktop version and see if you have the same issue?: https://desktop.kmr.nz/gene/SPAC20G8.05c

I think it worked, I couldn't replicate the issue on your desktop version. When the previous section highlights, it is already partially on screen. The image shows the point at which the previous section starts highlighting now:
image

@kimrutherford
Copy link
Member

When the previous section highlights, it is already partially on screen.

It's difficult to get the balance right.

I've changed the sensitivity again to a half-way setting. The change will be on pombase.org in the morning. When you are back at work could you test it again? Thanks.

@ValWood
Copy link
Member Author

ValWood commented Jan 3, 2025

I think it's better. For me it could still have more contrast but see What PAscal thinks.

I notice that Expression, modification and Interactions are 'linked" is that intentional?

@PCarme
Copy link
Contributor

PCarme commented Jan 6, 2025

I've changed the sensitivity again to a half-way setting. The change will be on pombase.org in the morning. When you are back at work could you test it again? Thanks.

That's better now. The previous section doesn't light up until it noticeably appears on screen, at least in Safari.

@PCarme
Copy link
Contributor

PCarme commented Jan 6, 2025

For me it could still have more contrast but see What PAscal thinks.

Maybe ? Personally, I think it is noticeable enough as it is

@kimrutherford
Copy link
Member

I notice that Expression, modification and Interactions are 'linked" is that intentional?

Could you provide an example page where that happens?

That's better now. The previous section doesn't light up until it noticeably appears on screen, at least in Safari.

Excellent. Thanks for checking.

For me it could still have more contrast but see What PAscal thinks.

Maybe ? Personally, I think it is noticeable enough as it is

Let's have a chat on Zoom sometime. If it helps we can try a few different styles while we chat.

@ValWood
Copy link
Member Author

ValWood commented Jan 8, 2025

on this page modifications and expression are linked (but not interactions)
https://www.pombase.org/gene/SPAC1610.01

@ValWood
Copy link
Member Author

ValWood commented Jan 8, 2025

https://www.pombase.org/gene/SPBC19F8.04c

clicking expression has the vertical bar also on interactions and homologs

Screenshot 2025-01-08 at 11 07 01

sequence and transcripts identifies external references

Screenshot 2025-01-08 at 11 06 54

@kimrutherford
Copy link
Member

Yep, for me too because they're all on screen at the same time:

That's how it's implemented at the moment: #2271 (comment)

Also all the sections that are on screen are highlighted in the menu, not just the first.

@ValWood
Copy link
Member Author

ValWood commented Jan 14, 2025

Lets chat about this briefly tomorrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants