-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sub menus #2271
Comments
This comment was marked as outdated.
This comment was marked as outdated.
not necessarily more noticeable , but might be better if they were better differentiated. |
We could indent them more? |
For comparison, we have a sub-nested menu in the documentation: https://www.pombase.org/downloads |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
I think the plan is to highlight the menu item(s) as they scroll into view. |
This comment was marked as resolved.
This comment was marked as resolved.
There are fewer bugs now so I've released the changes. For now the highlighting is quite subtle but it's easy to change. Also all the sections that are on screen are highlighted in the menu, not just the first. That was easier to implement so I thought we could give that a go first. Let's chat about it on the call. |
It's only implemented for gene pages so far. I'll add it to the other pages (publications, terms, genotypes, alleles) once we've had a chat about it. |
I just noticed this, nice. |
Hi Pascal. Which browser is that? |
I thought I'd start with quite subtle highlighting and then we can make it stronger if needed. It's a very easy thing to experiment with live on a call sometime to try a few options. |
Hi Kim, I'm using Safari. |
OK, thanks. That's the one browser I can't test. Firefox and Chrome don't seem to have the same problem. In my desktop version I've made the sensitivity a little bit lower. Could you try my desktop version and see if you have the same issue?: https://desktop.kmr.nz/gene/SPAC20G8.05c Thanks! |
I think it worked, I couldn't replicate the issue on your desktop version. When the previous section highlights, it is already partially on screen. The image shows the point at which the previous section starts highlighting now: |
It's difficult to get the balance right. I've changed the sensitivity again to a half-way setting. The change will be on pombase.org in the morning. When you are back at work could you test it again? Thanks. |
I think it's better. For me it could still have more contrast but see What PAscal thinks. I notice that Expression, modification and Interactions are 'linked" is that intentional? |
That's better now. The previous section doesn't light up until it noticeably appears on screen, at least in Safari. |
Maybe ? Personally, I think it is noticeable enough as it is |
Could you provide an example page where that happens?
Excellent. Thanks for checking.
Let's have a chat on Zoom sometime. If it helps we can try a few different styles while we chat. |
on this page modifications and expression are linked (but not interactions) |
https://www.pombase.org/gene/SPBC19F8.04c clicking expression has the vertical bar also on interactions and homologs sequence and transcripts identifies external references |
Yep, for me too because they're all on screen at the same time: That's how it's implemented at the moment: #2271 (comment)
|
Lets chat about this briefly tomorrow |
When the sub-menus are opened it's a bit difficult to notice which are sub menus.
If these could be coloured slightly differently it might help?
The text was updated successfully, but these errors were encountered: