-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[init] add _corral and _repo folders to .gitignore #150
Comments
I was the one who suggested those additions to README so I will voice my opinion on this. I think it should only add the lines iff .gitignore exists already. On that point, it definitely should be a flag, not on by default so we are not forcing a user into undoing work just because they wanted corral init. If .gitignore is present and the flag is given, I see no reason why we cannot safety assume Git is used and the user wants corral folders to be ignored. My other thought on the matter though is I would typically run corral init then git init, so then in order for corral to add to .gitignore it would have to create the file, or the user would have to run the two inits in reverse of what I would expect AND create a .gitignore (likely blank). @fibric How did you see this working with respect to the order of steps a user goes through? |
Corral won't find a I think Corral can check for the presence of the If https://github.com/ponylang/library-scaffolding-generator is still alive, it also could care about the |
Closing. Creation of a default .gitignore should be part of #147 when it is implemented. |
It's stated in the
Getting started using Corral
section of theREADME.md
to add the folder_corral
and_repo
to the.gitignore
file. I think this can be done by the init command that is described ealier in theREADME.md
So far
init
doesn't create it's own project folder and that's why I think this behavior should be hidden behind a CLI flag before making it the default behavior.The text was updated successfully, but these errors were encountered: