Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Good first issues can get truncated when posting to Zulip #18

Closed
SeanTAllen opened this issue Nov 7, 2023 · 1 comment · Fixed by #19
Closed

Good first issues can get truncated when posting to Zulip #18

SeanTAllen opened this issue Nov 7, 2023 · 1 comment · Fixed by #19
Assignees
Labels
good first issue Good for newcomers

Comments

@SeanTAllen
Copy link
Member

SeanTAllen commented Nov 7, 2023

This happens immediately out of the gate. We are using https://github.com/zulip/github-actions-zulip/tree/main/send-message to send messages to Zulip. It maxes the content out at 10,000 bytes which we already go over. We need to programmatically handle without using the Zulip github action.

We need our own script to post instead of the aforementioned Github action that can only post a single message. We will have 1 to N messages to post based on the unknown size of good first issues.

We want to:

Post our first message to a new topic and find a good place to cut at bytes below the limit and then keep slicing in a pleasing manner to post multiple add-ons in the topic until we are done.

Doing this in bash is probably awful. Our standard that we have decided on is using python for this. If someone can get a python script working, they can work with @SeanTAllen to figure out deployment and running.

@SeanTAllen SeanTAllen added enhancement help wanted Extra attention is needed good first issue Good for newcomers labels Nov 7, 2023
@ponylang-main ponylang-main added the discuss during sync Should be discussed during an upcoming sync label Nov 7, 2023
@SeanTAllen SeanTAllen removed the discuss during sync Should be discussed during an upcoming sync label Nov 7, 2023
@SeanTAllen
Copy link
Member Author

Deep links into Python configuration and sending a message:

https://zulip.com/api/configuring-python-bindings
https://zulip.com/api/send-message

For configuration, we'd be using the "environment variable" approach.

@ponylang-main ponylang-main added the discuss during sync Should be discussed during an upcoming sync label Dec 9, 2023
@SeanTAllen SeanTAllen removed the help wanted Extra attention is needed label Dec 9, 2023
@SeanTAllen SeanTAllen self-assigned this Dec 9, 2023
SeanTAllen added a commit that referenced this issue Dec 9, 2023
The Zulip API has a max message size and our "good first issues"
posting hits it resulting in message truncation and a loss of
content.

This commit adds a Python script to batch up "good first issues"
content into 1 or more messages so that it doesn't get truncated.

Also includes new image to run in as we need additional dependencies
that the "post sync" image doesn't need.

And this adds a PR check to link the python script and make sure it
is all kosher.

Fixes #18
SeanTAllen added a commit that referenced this issue Dec 9, 2023
The Zulip API has a max message size and our "good first issues"
posting hits it resulting in message truncation and a loss of
content.

This commit adds a Python script to batch up "good first issues"
content into 1 or more messages so that it doesn't get truncated.

Also includes new image to run in as we need additional dependencies
that the "post sync" image doesn't need.

And this adds a PR check to link the python script and make sure it
is all kosher.

Fixes #18
SeanTAllen added a commit that referenced this issue Dec 9, 2023
The Zulip API has a max message size and our "good first issues"
posting hits it resulting in message truncation and a loss of
content.

This commit adds a Python script to batch up "good first issues"
content into 1 or more messages so that it doesn't get truncated.

Also includes new image to run in as we need additional dependencies
that the "post sync" image doesn't need.

And this adds a PR check to link the python script and make sure it
is all kosher.

Fixes #18
SeanTAllen added a commit that referenced this issue Dec 9, 2023
The Zulip API has a max message size and our "good first issues"
posting hits it resulting in message truncation and a loss of
content.

This commit adds a Python script to batch up "good first issues"
content into 1 or more messages so that it doesn't get truncated.

Also includes new image to run in as we need additional dependencies
that the "post sync" image doesn't need.

And this adds a PR check to link the python script and make sure it
is all kosher.

Fixes #18
SeanTAllen added a commit that referenced this issue Dec 9, 2023
The Zulip API has a max message size and our "good first issues"
posting hits it resulting in message truncation and a loss of
content.

This commit adds a Python script to batch up "good first issues"
content into 1 or more messages so that it doesn't get truncated.

Also includes new image to run in as we need additional dependencies
that the "post sync" image doesn't need.

And this adds a PR check to link the python script and make sure it
is all kosher.

Fixes #18
SeanTAllen added a commit that referenced this issue Dec 9, 2023
The Zulip API has a max message size and our "good first issues"
posting hits it resulting in message truncation and a loss of
content.

This commit adds a Python script to batch up "good first issues"
content into 1 or more messages so that it doesn't get truncated.

Also includes new image to run in as we need additional dependencies
that the "post sync" image doesn't need.

And this adds a PR check to link the python script and make sure it
is all kosher.

Fixes #18
SeanTAllen added a commit that referenced this issue Dec 9, 2023
The Zulip API has a max message size and our "good first issues"
posting hits it resulting in message truncation and a loss of
content.

This commit adds a Python script to batch up "good first issues"
content into 1 or more messages so that it doesn't get truncated.

Also includes new image to run in as we need additional dependencies
that the "post sync" image doesn't need.

And this adds a PR check to link the python script and make sure it
is all kosher.

Fixes #18
SeanTAllen added a commit that referenced this issue Dec 9, 2023
The Zulip API has a max message size and our "good first issues"
posting hits it resulting in message truncation and a loss of
content.

This commit adds a Python script to batch up "good first issues"
content into 1 or more messages so that it doesn't get truncated.

Also includes new image to run in as we need additional dependencies
that the "post sync" image doesn't need.

And this adds a PR check to link the python script and make sure it
is all kosher.

Fixes #18
SeanTAllen added a commit that referenced this issue Dec 9, 2023
The Zulip API has a max message size and our "good first issues"
posting hits it resulting in message truncation and a loss of
content.

This commit adds a Python script to batch up "good first issues"
content into 1 or more messages so that it doesn't get truncated.

Also includes new image to run in as we need additional dependencies
that the "post sync" image doesn't need.

And this adds a PR check to link the python script and make sure it
is all kosher.

Fixes #18
SeanTAllen added a commit that referenced this issue Dec 10, 2023
The Zulip API has a max message size and our "good first issues"
posting hits it resulting in message truncation and a loss of
content.

This commit adds a Python script to batch up "good first issues"
content into 1 or more messages so that it doesn't get truncated.

Also includes new image to run in as we need additional dependencies
that the "post sync" image doesn't need.

And this adds a PR check to link the python script and make sure it
is all kosher.

Fixes #18
SeanTAllen added a commit that referenced this issue Dec 10, 2023
The Zulip API has a max message size and our "good first issues"
posting hits it resulting in message truncation and a loss of
content.

This commit adds a Python script to batch up "good first issues"
content into 1 or more messages so that it doesn't get truncated.

Also includes new image to run in as we need additional dependencies
that the "post sync" image doesn't need.

And this adds a PR check to link the python script and make sure it
is all kosher.

Fixes #18
SeanTAllen added a commit that referenced this issue Dec 10, 2023
The Zulip API has a max message size and our "good first issues"
posting hits it resulting in message truncation and a loss of
content.

This commit adds a Python script to batch up "good first issues"
content into 1 or more messages so that it doesn't get truncated.

Also includes new image to run in as we need additional dependencies
that the "post sync" image doesn't need.

And this adds a PR check to link the python script and make sure it
is all kosher.

Fixes #18
SeanTAllen added a commit that referenced this issue Dec 10, 2023
The Zulip API has a max message size and our "good first issues"
posting hits it resulting in message truncation and a loss of
content.

This commit adds a Python script to batch up "good first issues"
content into 1 or more messages so that it doesn't get truncated.

Also includes new image to run in as we need additional dependencies
that the "post sync" image doesn't need.

And this adds a PR check to link the python script and make sure it
is all kosher.

Fixes #18
SeanTAllen added a commit that referenced this issue Dec 10, 2023
The Zulip API has a max message size and our "good first issues"
posting hits it resulting in message truncation and a loss of
content.

This commit adds a Python script to batch up "good first issues"
content into 1 or more messages so that it doesn't get truncated.

Also includes new image to run in as we need additional dependencies
that the "post sync" image doesn't need.

And this adds a PR check to link the python script and make sure it
is all kosher.

Fixes #18
SeanTAllen added a commit that referenced this issue Dec 10, 2023
The Zulip API has a max message size and our "good first issues"
posting hits it resulting in message truncation and a loss of
content.

This commit adds a Python script to batch up "good first issues"
content into 1 or more messages so that it doesn't get truncated.

Also includes new image to run in as we need additional dependencies
that the "post sync" image doesn't need.

And this adds a PR check to link the python script and make sure it
is all kosher.

Fixes #18
SeanTAllen added a commit that referenced this issue Dec 10, 2023
The Zulip API has a max message size and our "good first issues"
posting hits it resulting in message truncation and a loss of
content.

This commit adds a Python script to batch up "good first issues"
content into 1 or more messages so that it doesn't get truncated.

Also includes new image to run in as we need additional dependencies
that the "post sync" image doesn't need.

And this adds a PR check to link the python script and make sure it
is all kosher.

Fixes #18
SeanTAllen added a commit that referenced this issue Dec 10, 2023
The Zulip API has a max message size and our "good first issues"
posting hits it resulting in message truncation and a loss of
content.

This commit adds a Python script to batch up "good first issues"
content into 1 or more messages so that it doesn't get truncated.

Also includes new image to run in as we need additional dependencies
that the "post sync" image doesn't need.

And this adds a PR check to link the python script and make sure it
is all kosher.

Fixes #18
SeanTAllen added a commit that referenced this issue Dec 10, 2023
The Zulip API has a max message size and our "good first issues"
posting hits it resulting in message truncation and a loss of
content.

This commit adds a Python script to batch up "good first issues"
content into 1 or more messages so that it doesn't get truncated.

Also includes new image to run in as we need additional dependencies
that the "post sync" image doesn't need.

And this adds a PR check to link the python script and make sure it
is all kosher.

Fixes #18
SeanTAllen added a commit that referenced this issue Dec 10, 2023
The Zulip API has a max message size and our "good first issues"
posting hits it resulting in message truncation and a loss of
content.

This commit adds a Python script to batch up "good first issues"
content into 1 or more messages so that it doesn't get truncated.

Also includes new image to run in as we need additional dependencies
that the "post sync" image doesn't need.

And this adds a PR check to link the python script and make sure it
is all kosher.

Fixes #18
SeanTAllen added a commit that referenced this issue Dec 10, 2023
The Zulip API has a max message size and our "good first issues"
posting hits it resulting in message truncation and a loss of
content.

This commit adds a Python script to batch up "good first issues"
content into 1 or more messages so that it doesn't get truncated.

Also includes new image to run in as we need additional dependencies
that the "post sync" image doesn't need.

And this adds a PR check to link the python script and make sure it
is all kosher.

Fixes #18
SeanTAllen added a commit that referenced this issue Dec 10, 2023
The Zulip API has a max message size and our "good first issues"
posting hits it resulting in message truncation and a loss of
content.

This commit adds a Python script to batch up "good first issues"
content into 1 or more messages so that it doesn't get truncated.

Also includes new image to run in as we need additional dependencies
that the "post sync" image doesn't need.

And this adds a PR check to link the python script and make sure it
is all kosher.

Fixes #18
SeanTAllen added a commit that referenced this issue Dec 10, 2023
The Zulip API has a max message size and our "good first issues"
posting hits it resulting in message truncation and a loss of
content.

This commit adds a Python script to batch up "good first issues"
content into 1 or more messages so that it doesn't get truncated.

Also includes new image to run in as we need additional dependencies
that the "post sync" image doesn't need.

And this adds a PR check to link the python script and make sure it
is all kosher.

Fixes #18
SeanTAllen added a commit that referenced this issue Dec 10, 2023
The Zulip API has a max message size and our "good first issues"
posting hits it resulting in message truncation and a loss of
content.

This commit adds a Python script to batch up "good first issues"
content into 1 or more messages so that it doesn't get truncated.

Also includes new image to run in as we need additional dependencies
that the "post sync" image doesn't need.

And this adds a PR check to link the python script and make sure it
is all kosher.

Fixes #18
SeanTAllen added a commit that referenced this issue Dec 12, 2023
The Zulip API has a max message size and our "good first issues"
posting hits it resulting in message truncation and a loss of
content.

This commit adds a Python script to batch up "good first issues"
content into 1 or more messages so that it doesn't get truncated.

Also includes new image to run in as we need additional dependencies
that the "post sync" image doesn't need.

And this adds a PR check to link the python script and make sure it
is all kosher.

Fixes #18
@ponylang-main ponylang-main removed the discuss during sync Should be discussed during an upcoming sync label Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants