Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR should check "builder" image can build #20

Closed
SeanTAllen opened this issue Dec 9, 2023 · 1 comment · Fixed by #22
Closed

PR should check "builder" image can build #20

SeanTAllen opened this issue Dec 9, 2023 · 1 comment · Fixed by #22
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@SeanTAllen
Copy link
Member

SeanTAllen commented Dec 9, 2023 •
edited
Loading

As a check during PRs, we should have a job that verifies the builder image can be built
@SeanTAllen SeanTAllen added enhancement help wanted Extra attention is needed good first issue Good for newcomers labels Dec 9, 2023
@ponylang-main ponylang-main added the discuss during sync Should be discussed during an upcoming sync label Dec 9, 2023
@SeanTAllen SeanTAllen mentioned this issue Dec 9, 2023
Closed
@SeanTAllen SeanTAllen changed the title PR should check images can build PR should check "builder" image can build Dec 10, 2023
Merged
@ChristopherChristofi
Copy link
Contributor

Hello @SeanTAllen, I believe this should be resolved by new PR #22

SeanTAllen pushed a commit that referenced this issue Dec 10, 2023
@ChristopherChristofi
Add new workflow job for builder image verification (#22)
a6b41b8 
Fixes #20
@ponylang-main ponylang-main removed the discuss during sync Should be discussed during an upcoming sync label Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add new workflow job for builder image verification ChristopherChristofi/pony-sync-helper
3 participants
@SeanTAllen @ponylang-main @ChristopherChristofi