Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variables View goes into a weird state when you have a filter and switch language runtimes #1829

Open
dfalty opened this issue Nov 15, 2023 · 1 comment
Labels
area: variables Issues related to Variables category. bug Something isn't working

Comments

@dfalty
Copy link

dfalty commented Nov 15, 2023

Positron Version:

Positron Version: 2023.11.0 (Universal) build 1166
Code - OSS Version: 1.84.0
Commit: 1c59a02
Date: 2023-11-15T03:09:15.635Z
Electron: 25.9.2
ElectronBuildId: undefined
Chromium: 114.0.5735.289
Node.js: 18.15.0
V8: 11.4.183.29-electron.0
OS: Darwin arm64 22.6.0

Steps to reproduce the issue:

  1. Select an R language runtime
  2. Create a variable "x <- 1"
  3. Create another variable "myvariable <- 1"
  4. Search in the filter for "myvar" and observe that it should filter out just the one variable
  5. Without clearing the filter, select a Python language runtime from the dropdown menu
  6. Observe that "myvar" is still in the filter but it's not actually filtering the Python environment
  7. Press "x" on the filter to clear
  8. Select the R language runtime
  9. Observe that the filter text box is empty but the pane is still filtered and "x" variable doesn't appear

You are now in a weird state where new variables won't show unless it matches the past filter even though there is no text. I got into this state and was really confused as to why new variables weren't showing up. I tried selecting the refresh button, but it didn't do anything. I thought I broke the environment pane.

The way I found to get out of this state was to type into the filter and press "x" to cancel it and it will put you back to normal.

What did you expect to happen?

I actually expect that when I change to another language runtime, the filter either clears out or stays and actually applies. If that were the case, then the user wouldn't encounter the weird state.

@dfalty dfalty added the bug Something isn't working label Nov 15, 2023
@petetronic petetronic changed the title Environment Pane goes into a weird state when you have a filter and switch language runtimes Variables View goes into a weird state when you have a filter and switch language runtimes Nov 23, 2023
@petetronic petetronic added this to the Release Candidate milestone Feb 26, 2024
@wesm wesm added area: variables Issues related to Variables category. bug Something isn't working and removed bug Something isn't working labels Feb 29, 2024
@dhruvisompura
Copy link
Contributor

Mega-Triage Note - 2/5/2025: Let's clear the filters when we change runtimes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: variables Issues related to Variables category. bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants