Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ark: Control flow / some keyword completions aren't being populated #1850

Open
Tracked by #1603
DavisVaughan opened this issue Nov 17, 2023 · 0 comments
Open
Tracked by #1603
Assignees
Labels
area: completions Issues related to Completions area: kernels Issues related to Jupyter kernels and LSP servers lang: r

Comments

@DavisVaughan
Copy link
Contributor

DavisVaughan commented Nov 17, 2023

For example, function

Screen.Recording.2023-11-17.at.2.57.00.PM.mov

They are being purposefully skipped here:
https://github.com/posit-dev/amalthea/blob/435f95c4d5187832937ae68c52740be52510e54d/crates/ark/src/lsp/completions/session.rs#L605

I think it makes sense to skip them there and add them elsewhere or maybe to mark them as special types of completions from there (in particular handle break and next specially, i.e. not as functions!)

@DavisVaughan DavisVaughan added this to the Internal Preview milestone Nov 17, 2023
@wesm wesm added the lang: r label Feb 29, 2024
@lionel- lionel- added area: kernels Issues related to Jupyter kernels and LSP servers area: completions Issues related to Completions labels May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: completions Issues related to Completions area: kernels Issues related to Jupyter kernels and LSP servers lang: r
Projects
None yet
Development

No branches or pull requests

5 participants