Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Positron Version: Server About dialog shows outdated information #2059

Open
jmcphers opened this issue Jan 11, 2024 · 2 comments
Open

Positron Version: Server About dialog shows outdated information #2059

jmcphers opened this issue Jan 11, 2024 · 2 comments
Labels
area: workbench Issues related to Workbench category.
Milestone
Release Candidate

Comments

@jmcphers
Copy link
Collaborator

To reproduce, open the Command Palette in Positron Server and run the Help: About command.

image

This information is very outdated; it should show the current version of Positron and VS Code (currently 2024.01 and 1.85 respectively)
@jmcphers
Copy link
Collaborator Author

This seems to be an artifact of running in dev server mode. In particular the 1.82 value is coming from Code - OSS upstream!

positron/src/vs/platform/product/common/product.ts

Lines 52 to 63 in 84ade73

// Web environment or unknown
else {
// Built time configuration (do NOT modify)
product = { /*BUILD->INSERT_PRODUCT_CONFIGURATION*/ } as IProductConfiguration;
// Running out of sources
if (Object.keys(product).length === 0) {
Object.assign(product, {
version: '1.82.0-dev',
// --- Start Positron ---
positronVersion: '2022.10.0',

Ideally we'd get this from the product JSON file as that's where the About dialog gets them on Electron builds. It's not immediately clear to me why that doesn't happen in server mode.

@jmcphers jmcphers added this to the Release Candidate milestone Feb 20, 2024
@wesm wesm added the area: workbench Issues related to Workbench category. label Feb 29, 2024
@juliasilge juliasilge mentioned this issue Apr 29, 2024
Closed
@sharon-wang sharon-wang mentioned this issue Aug 28, 2024
Merged
sharon-wang added a commit that referenced this issue Aug 28, 2024
@sharon-wang
use correct property name for reh-web and web positronBuildNumber (#…
569772e 
…4515)

### Description

- A follow-up to #1618 and #4426
- Fixes the incorrect product.json property name by changing
`buildNumber` to `positronBuildNumber` in the reh-web and web, resolving
an issue where the build number always shows as `0` in dev and release
builds for reh-web
- I just saw #2059 which is
related, but this does not resolve that issue, which is specific to dev
builds where product.json doesn't get injected. Note that the hardcoded
product info in that code doesn't include `positronBuildNumber`, so it
will display `0` by default.

#### Preview


![image](https://github.com/user-attachments/assets/e86f6fc8-3788-4656-a950-39025fc0dce6)

### QA Notes

See posit-dev/positron-builds#49 for
instructions on how to run a build.

The build's "About Positron" dialog should show the actual build number,
which is the number of commits since the anchor commit in a release
build.
@sharon-wang sharon-wang changed the title Server: About dialog shows outdated information Positron Version: Server About dialog shows outdated information Oct 22, 2024
@sharon-wang sharon-wang removed their assignment Nov 4, 2024
@jmcphers
Copy link
Collaborator Author

jmcphers commented Feb 5, 2025

@melissa-barca suggests this may also be a problem on Workbench (not just in dev mode). if true, we should address soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: workbench Issues related to Workbench category.
Projects
None yet
Milestone
Release Candidate
Development

No branches or pull requests
3 participants
@wesm @jmcphers @sharon-wang