Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine the color decorators scope #2315

Open
jennybc opened this issue Feb 23, 2024 · 3 comments
Open

Refine the color decorators scope #2315

jennybc opened this issue Feb 23, 2024 · 3 comments
Labels
area: ui Issues related to UI category.

Comments

@jennybc
Copy link
Member

jennybc commented Feb 23, 2024

Splitting this out from #1613. The original topic there is a feature request (that github issue numbers be auto-linked in NEWS.md).

However that provoked much discussion of generally over-eager color decoration in Positron. Some of this may be inherited from VS Code, but some of it may be due to choices we've made. See #1613 for more discussion.

This issue is for the more limited, more bug-fix-y issue of suppressing inappropriate color decoration.

@jennybc jennybc added this to the Release Candidate milestone Feb 23, 2024
@posit-dev posit-dev deleted a comment from jmcphers Feb 23, 2024
@posit-dev posit-dev deleted a comment from jmcphers Feb 23, 2024
@jennybc
Copy link
Member Author

jennybc commented Feb 23, 2024

From the other thread, here's an example of over-eager color decoration. An issue number should not be decorated with a color picker when authoring a commit message and this appears to affect Positron but not VS Code. Screenshot from other thread, but I can also reproduce the behaviour in Positron Version: 2024.02.0 (Universal) build 1567. And in VS Code Version: 1.86.1, this doesn't happen in a git commit message. So it's something we've done.

Screenshot 2024-02-23 at 1 49 11 PM

@jennybc
Copy link
Member Author

jennybc commented Feb 23, 2024

If we don't fix this, maybe we can frame this as Positron's synesthesia feature, which associates certain colors with your GitHub issues 🌈

@juliasilge
Copy link
Contributor

Look at this (from Bluesky) happening for an address as well 🙈

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: ui Issues related to UI category.
Projects
None yet
Development

No branches or pull requests

3 participants