Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intermittent Electron Integration test failure: Unknown method $extensionTestsExecute #2379

Open
jmcphers opened this issue Mar 5, 2024 · 1 comment
Labels
area: builds Issues related to Builds category. bug Something isn't working flakiness

Comments

@jmcphers
Copy link
Collaborator

jmcphers commented Mar 5, 2024

This failure has been showing up frequently in our Electron Integration CI tests:

[18161:0228/234323.998548:INFO:CONSOLE(418)]
"Error: Unknown method $extensionTestsExecute on actor ExtHostCustomEditors",
source: vscode-file://vscode-app/home/runner/work/positron/positron/out/vs/workbench/services/extensions/common/abstractExtensionService.js (418)

Here are a bunch of examples of full test runs/logs from a variety of PRs by a variety of developers:

https://github.com/posit-dev/positron/actions/runs/7876449164/job/21490489953
https://github.com/posit-dev/positron/actions/runs/8088115350/attempts/1?pr=2358
https://github.com/posit-dev/positron/actions/runs/8088115350/attempts/2?pr=2358
https://github.com/posit-dev/positron/actions/runs/8090350064/job/22107697614?pr=2356
https://github.com/posit-dev/positron/actions/runs/8090241463/job/22107412078?pr=2360

Sometimes, CI tests have to be re-run two or three times to get a clean run.

We should either figure out why this test is flaky (and fix it so it isn't) or disable it.

Slack thread with more discussion: https://positpbc.slack.com/archives/C04FPQK3H9C/p1709164149296819

@jmcphers jmcphers added the bug Something isn't working label Mar 5, 2024
@jmcphers jmcphers added this to the Release Candidate milestone Mar 5, 2024
@jmcphers jmcphers added the area: builds Issues related to Builds category. label Mar 5, 2024
@petetronic
Copy link
Collaborator

We disabled the Electron Integration tests on CI as it was blocking a significant number of PRs. We need to ensure it runs reliably before re-enabling.

seeM added a commit that referenced this issue Mar 14, 2024
Attempts to address #2379. I reenabled tests since the bug seems quite
low probably, and CI seems like the most reliably way to check whether
this fix actually works.
@wesm wesm added the flakiness label Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: builds Issues related to Builds category. bug Something isn't working flakiness
Projects
None yet
Development

No branches or pull requests

3 participants