Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ark: Completions should be sensitive to the text on the RHS of the cursor #2574

Open
Tracked by #1603
lionel- opened this issue Mar 29, 2024 · 5 comments
Open
Tracked by #1603
Assignees
Labels
area: completions Issues related to Completions area: kernels Issues related to Jupyter kernels and LSP servers bug Something isn't working lang: r support

Comments

@lionel-
Copy link
Contributor

lionel- commented Mar 29, 2024

From https://github.com/posit-dev/positron-beta/discussions/47

Screen Recording 2024-03-29 at 09 51 35

I think that's annoying enough, and probably not too hard to fix, we'd want to add that to public beta?

@lionel- lionel- added bug Something isn't working lang: r labels Mar 29, 2024
@juliasilge juliasilge added this to the Release Candidate milestone Apr 1, 2024
@juliasilge
Copy link
Contributor

Is this a completions issue that should get added to #1603?

@lionel- lionel- mentioned this issue Apr 2, 2024
23 tasks
@lionel-
Copy link
Contributor Author

lionel- commented Apr 2, 2024

I've just added it

@lionel-
Copy link
Contributor Author

lionel- commented Apr 19, 2024

Relatedly, @hadley notes:

can completions use text to the right of the cursor as well as text to the left?
i.e. I type build_articles() which doesn’t work because I haven’t loaded pkgdown. So I press up, then cmd + left arrow and type pkgdown:: — that then autocompletes to pkgdown::as_pkgdown()build_articles()

@lionel- lionel- changed the title Ark: Parentheses are always added when using autocomplete Ark: Completions should be sensitive to the text on the RHS of the cursor Apr 19, 2024
@lionel- lionel- added area: kernels Issues related to Jupyter kernels and LSP servers area: completions Issues related to Completions labels May 16, 2024
@olivroy
Copy link

olivroy commented Sep 26, 2024

Is this related to this? Or should I open a new issue.

If I attempt to complete in this state (to the left of brackets

image

and I accept the completion suggestion.
This gets inserted
image

Also,I can't see help text for parameters on hovering

i.e. try to see the docs for the path argument here.
image

Also, when pressing F1 at that location, I get the info message

@juliasilge
Copy link
Contributor

We are tracking the extra parentheses being added here: #4441

I'm not sure we do have anything about the behavior of F1 inside parentheses, so that would be a new issue but I do notice that RStudio also doesn't bring up Help in that situation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: completions Issues related to Completions area: kernels Issues related to Jupyter kernels and LSP servers bug Something isn't working lang: r support
Projects
None yet
Development

No branches or pull requests

5 participants