Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal: Streamline restarting a session via the extension API #2623

Open
seeM opened this issue Apr 3, 2024 · 1 comment
Open

Proposal: Streamline restarting a session via the extension API #2623

seeM opened this issue Apr 3, 2024 · 1 comment
Labels
area: api Issues related to API category.
Milestone
Release Candidate

Comments

@seeM
Copy link
Contributor

seeM commented Apr 3, 2024

Currently, positron.runtime.restartSession resolves when the restart sequence is started. Could we update it to resolve when the session enters the ready state, or reject after a timeout?
@seeM seeM added the area: api Issues related to API category. label Apr 3, 2024
@seeM seeM assigned seeM and unassigned seeM Apr 3, 2024
@jmcphers
Copy link
Collaborator

jmcphers commented Apr 5, 2024

No reason we couldn't do this, so long as we audit existing usage to make sure it isn't awaiting this in such a way that the UI won't ever update to the restarting phase.

@seeM seeM added this to the Release Candidate milestone Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: api Issues related to API category.
Projects
None yet
Milestone
Release Candidate
Development

No branches or pull requests
2 participants
@jmcphers @seeM