Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review Console performance of escape-character aware processing #267

Open
petetronic opened this issue Mar 10, 2023 · 1 comment
Open

Review Console performance of escape-character aware processing #267

petetronic opened this issue Mar 10, 2023 · 1 comment
Labels
area: console Issues related to Console category. performance

Comments

@petetronic
Copy link
Collaborator

In the event that a large amount of output is sent to the console, we should take another look at the performance impact of the ansi escape character aware processing that we do. It will behoove us to at least look at whether simple pre-scanning for escape characters or opportunities for reducing string concatenation will help with performance.

@petetronic petetronic added this to the Public Beta milestone Mar 10, 2023
@kevinushey
Copy link
Contributor

An example to stress-test with R code; printing 20 lines with 1,000,000 characters:

for (i in 1:20) {
  print(paste(sample(letters, 1E6, TRUE), collapse = ""))
}

The main concern in my mind is making sure a user is able to recover from an "overloaded" console. (Usually, clearing the console history will be enough).

We might also need to be aware of issues like this when replaying saved console outputs into the console history; we've had a couple issues in RStudio where the IDE would hang on startup as it was trying to render an overly-large saved console history.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: console Issues related to Console category. performance
Projects
None yet
Development

No branches or pull requests

3 participants