Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Progress bar does not update, instead append at the end #3723

Closed
dkgaraujo opened this issue Jun 28, 2024 · 3 comments
Closed

Progress bar does not update, instead append at the end #3723

dkgaraujo opened this issue Jun 28, 2024 · 3 comments
Assignees
@seeM
Labels
area: notebooks Issues related to Notebooks category. bug Something isn't working lang: python support
Milestone
2024.11.0 Pre-Rel...

Comments

@dkgaraujo
Copy link

Positron Version:

Positron Version: 2024.06.1 (Universal) build 27
Code - OSS Version: 1.90.0
Commit: a893e5b
Date: 2024-06-26T02:08:06.673Z
Electron: 29.4.0
Chromium: 122.0.6261.156
Node.js: 20.9.0
V8: 12.2.281.27-electron.0
OS: Darwin x64 23.5.0

Steps to reproduce the issue:

  1. Create new notebook
  2. in a python cell, pip install a package with !pip install package

What did you expect to happen?

the progress bar should update automatically, and not have a new version show up below the current one with every status update (see fig)

Screenshot 2024-06-28 at 23 05 36

Were there any error messages in the output or Developer Tools console?

No
@dkgaraujo dkgaraujo added the bug Something isn't working label Jun 28, 2024
@petetronic petetronic added lang: python area: notebooks Issues related to Notebooks category. labels Jun 29, 2024
@petetronic
Copy link
Collaborator

Thank you for reporting this, I was able to reproduce the issue.
Note that the Console does not have this issue and correctly redraws the same line as the progress bar updates.

@seeM
Copy link
Contributor

seeM commented Jun 30, 2024 •
edited
Loading

It works as expected in VSCode notebooks, so it's not an issue with the output views. I suspect it's in our notebook controllers.

Related to #284, but not quite the same.

@juliasilge juliasilge added this to the Future milestone Jul 5, 2024
@seeM seeM mentioned this issue Oct 8, 2024
Merged
@seeM seeM self-assigned this Oct 8, 2024
@seeM seeM modified the milestones: Future, 2024.11.0 Pre-Release Oct 8, 2024
seeM added a commit that referenced this issue Oct 10, 2024
@seeM
Fix notebook stream output ANSI code handling (#4937)
38edfc2 
Addresses #3723. The main change is in `handleRuntimeMessageStream`,
where we now append to an existing output if possible.
@midleman
Copy link
Contributor

Verified Fixed

Positron Version(s) : 2024.11.0-49
OS Version(s) : MacOS

Test scenario(s)

Confirmed progress bar displays as expected in notebook.
Image

Link(s) to TestRail test cases run or created:

isabelizimm pushed a commit that referenced this issue Oct 16, 2024
@seeM @isabelizimm
Fix notebook stream output ANSI code handling (#4937)
29f91a4 
Addresses #3723. The main change is in `handleRuntimeMessageStream`,
where we now append to an existing output if possible.
isabelizimm pushed a commit that referenced this issue Oct 16, 2024
@seeM @isabelizimm
Fix notebook stream output ANSI code handling (#4937)
4fe9c5e 
Addresses #3723. The main change is in `handleRuntimeMessageStream`,
where we now append to an existing output if possible.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@seeM seeM

Labels
area: notebooks Issues related to Notebooks category. bug Something isn't working lang: python support
Projects
None yet
Milestone
2024.11.0 Pre-Release
Development

No branches or pull requests
5 participants
@seeM @petetronic @juliasilge @dkgaraujo @midleman