Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolve copyright in workbench.desktop.main.js (and other files) #44

Open
kevinushey opened this issue Oct 31, 2022 · 2 comments
Open

resolve copyright in workbench.desktop.main.js (and other files) #44

kevinushey opened this issue Oct 31, 2022 · 2 comments
Labels
area: core Issues related to Core category.
Milestone
Release Candidate

Comments

@kevinushey
Copy link
Contributor

The generated workbench.desktop.main.js file is given a copyright not including MIT:

/*!--------------------------------------------------------
 * Copyright (C) Microsoft Corporation. All rights reserved.
 *--------------------------------------------------------*/

This is also true for some copied resource files, e.g. processExplorerMain.css has:

/*!--------------------------------------------------------
 * Copyright (C) Microsoft Corporation. All rights reserved.
 *--------------------------------------------------------*/
/*---------------------------------------------------------
 * Copyright (c) Microsoft Corporation. All rights reserved.
 *--------------------------------------------------------*/
/*---------------------------------------------------------------------------------------------
 *  Copyright (c) Microsoft Corporation. All rights reserved.
 *  Licensed under the MIT License. See License.txt in the project root for license information.
 *--------------------------------------------------------------------------------------------*/

IIUC, this header is being inserted here:

https://github.com/rstudio/positron/blob/36a65de90d3f1153bc081049533d90d179526229/build/lib/optimize.ts#L198-L202

Can we safely just remove (or change) the default copyright header here?
@kevinushey kevinushey changed the title resolve copyright in workbench.desktop.main.js resolve copyright in workbench.desktop.main.js (and other files) Oct 31, 2022
@kevinushey
Copy link
Contributor Author

kevinushey commented Oct 31, 2022 •
edited
Loading

See also:

https://github.com/rstudio/positron/blob/36a65de90d3f1153bc081049533d90d179526229/src/vs/nls.build.ts#L52-L73

https://github.com/rstudio/positron/blob/36a65de90d3f1153bc081049533d90d179526229/build/lib/nls.ts#L51-L63

https://github.com/rstudio/positron/blob/36a65de90d3f1153bc081049533d90d179526229/build/lib/optimize.ts#L113-L122

@kevinushey
Copy link
Contributor Author

Probably not necessary for MVP? But would be a blocker for a public release.

@kevinushey kevinushey added this to the Public Beta milestone Feb 15, 2023
@wesm wesm added the area: core Issues related to Core category. label Feb 29, 2024
wesm pushed a commit that referenced this issue Mar 28, 2024
@petetronic
Merged PR posit-dev/positron-python#44: Add initial support for env p…
9e6af79 
…ane details of table dataframes

Merge pull request #44 from posit-dev/env-pane-df

Add initial support for env pane details of table dataframes
--------------------
Commit message for posit-dev/positron-python@9239f43:

Add initial support for env pane details of table dataframes

Summarize the children of pandas and polars as their column series.


Authored-by: Pete Farland <[email protected]>
Signed-off-by: Pete Farland <[email protected]>
wesm pushed a commit that referenced this issue Mar 28, 2024
@petetronic @wesm
Merged PR posit-dev/positron-python#44: Add initial support for env p…
c12e8e0 
…ane details of table dataframes

Merge pull request #44 from posit-dev/env-pane-df

Add initial support for env pane details of table dataframes
--------------------
Commit message for posit-dev/positron-python@9239f43:

Add initial support for env pane details of table dataframes

Summarize the children of pandas and polars as their column series.


Authored-by: Pete Farland <[email protected]>
Signed-off-by: Pete Farland <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: core Issues related to Core category.
Projects
None yet
Milestone
Release Candidate
Development

No branches or pull requests
3 participants
@wesm @petetronic @kevinushey