From ccfc4460b2eb1e1f658cdb7d000f546a6ff6bc82 Mon Sep 17 00:00:00 2001 From: Marie Idleman Date: Thu, 5 Dec 2024 13:59:50 -0600 Subject: [PATCH] fix --- .github/workflows/positron-merge-to-branch.yml | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/.github/workflows/positron-merge-to-branch.yml b/.github/workflows/positron-merge-to-branch.yml index 41aa7e503d5..47687e3a065 100644 --- a/.github/workflows/positron-merge-to-branch.yml +++ b/.github/workflows/positron-merge-to-branch.yml @@ -86,7 +86,7 @@ jobs: unit-tests: runs-on: ubuntu-latest - timeout-minutes: 20 + timeout-minutes: 30 env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} POSITRON_BUILD_NUMBER: 0 # CI skips building releases @@ -132,7 +132,7 @@ jobs: integration-tests: runs-on: ubuntu-latest-4x - timeout-minutes: 20 + timeout-minutes: 30 env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} POSITRON_BUILD_NUMBER: 0 # CI skips building releases @@ -182,8 +182,7 @@ jobs: run: DISPLAY=:10 ./scripts/test-web-integration.sh --browser chromium slack-notify: - # if: ${{ failure() && inputs.e2e_grep == '' }} - if: ${{ inputs.e2e_grep == '' }} + if: ${{ failure() && inputs.e2e_grep == '' }} needs: [unit-tests, integration-tests, e2e-electron] runs-on: ubuntu-latest steps: @@ -193,8 +192,14 @@ jobs: repo_token: ${{ secrets.POSITRON_GITHUB_PAT }} slack_webhook_url: ${{ secrets.SLACK_TEST_RESULTS_WEBHOOK_URL }} notify_on: "failure" - # adding this for time being so i can monitor slack notifications to make sure - # behavior is as expected. + + # adding this for time being so i can monitor slack notifications to make sure + # behavior is as expected. + slack-notify-test: + if: ${{ always() && inputs.e2e_grep == '' }} + needs: [unit-tests, integration-tests, e2e-electron] + runs-on: ubuntu-latest + steps: - name: Send Slack Notification uses: midleman/slack-workflow-status@master with: