Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of sensi computations with applied RAs #1061

Open
pet-mit opened this issue Jun 24, 2024 · 0 comments · May be fixed by #1108
Open

Improve performance of sensi computations with applied RAs #1061

pet-mit opened this issue Jun 24, 2024 · 0 comments · May be fixed by #1108
Labels
feature New feature or request

Comments

@pet-mit
Copy link
Collaborator

pet-mit commented Jun 24, 2024

Describe the current behavior

When computing sensitivity values with applied RAs, a network clone is created for every state with applied RAs.

Describe the expected behavior

Improve performance by avoiding the creation of new clone, and instead re-using existing clones (but we will have to un-apply RAs in-between states). (see TODO in SystematicSensitivityAdapter around line 111)

Describe the motivation

Performance boost

Extra Information

No response

@pet-mit pet-mit added the feature New feature or request label Jun 24, 2024
@pet-mit pet-mit linked a pull request Aug 8, 2024 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant