Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for Seaworthy itself don't work on pytest 4.0 #84

Open
JayH5 opened this issue Nov 28, 2018 · 0 comments
Open

Tests for Seaworthy itself don't work on pytest 4.0 #84

JayH5 opened this issue Nov 28, 2018 · 0 comments

Comments

@JayH5
Copy link
Contributor

JayH5 commented Nov 28, 2018

Some of our tests for Seaworthy itself don't work on pytest 4 because we call some of the Seaworthy fixtures directly in order to test them. We get errors like:

_pytest.warning_types.RemovedInPytest4Warning: Fixture "docker_helper" called directly. Fixtures are not meant to be called directly, are created automatically when test functions request them as parameters. See https://docs.pytest.org/en/latest/fixture.html for more information.

While Seaworthy itself seems to work fine with pytest 4, this is currently causing builds to fail.

These warnings can be configured to not result in failures, but in pytest 4.1 that will break too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant