You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've been using undom for my tests in quite a few projects. I just started exploring hooks in one of my own branches, and realized latest PreactX does not work with undom.
yup this issue is better suited on the undom repo. We are very likely using some features of the DOM which undom doesn't stub out. That's hardly an issue in Preact. If you do create an issue on the undom repo, be sure to include the error message you are getting. Looking at the fiddle it seems like it doesn't use the umd bundle which is built for the browser and thus trips up over some module specific code (exports/imports).
Update if anyone runs into this: I've patched the JSFiddle to work with Preact: https://jsfiddle.net/developit/9jzyv6we/
Undom was missing .localName and .data (developit/undom#32), but the breakage was actually due to a fix JSFiddle rolled out that enabled strict mode for JS.
I've been using undom for my tests in quite a few projects. I just started exploring hooks in one of my own branches, and realized latest PreactX does not work with undom.
I took the linked fiddle from undom, and replaced the preact resource with: http://npmcdn.com/preact@next
With that as the only change, the fiddle stops working:
https://jsfiddle.net/vu3qjarw/
I'm not sure if undom needs updating to implement some DOM features that PreactX now requires, or if PreactX needs updates to the render?
Perhaps this is better suited as on issue on the undom project? If so, let me know and I can recreate it there.
Thanks!
The text was updated successfully, but these errors were encountered: