Kobler: New adapter (#3667) #3684
Conversation
| try { | ||
| final ExtImpKobler impExt = parseImpExt(imp); | ||
|
|
||
| if (bidRequest.getImp().indexOf(imp) == 0) { |
There was a problem hiding this comment.
don't use indexOf, it spends unnecessary execution time to check each imp
| } | ||
|
|
||
| final Imp modifiedImp = modifyImp(imp, impExt, bidRequest); | ||
| requests.add(makeHttpRequest(bidRequest, modifiedImp, testMode)); |
There was a problem hiding this comment.
the bidder should send only a single request with all the imps instead of a request per imp
| return imp.toBuilder() | ||
| .bidfloor(resolvedBidFloor.getValue()) | ||
| .bidfloorcur(resolvedBidFloor.getCurrency()) | ||
| .ext(mapper.mapper().valueToTree(extImpKobler)) |
There was a problem hiding this comment.
I don't see imp.ext change in Go
|
|
||
| for (Imp imp : bidRequest.getImp()) { | ||
| try { | ||
| final ExtImpKobler impExt = parseImpExt(imp); |
There was a problem hiding this comment.
we don't need to parse imp.ext if it's not the first imp
| return bidsFromResponse(bidResponse, errors); | ||
| } | ||
|
|
||
| private List<BidderBid> bidsFromResponse(BidResponse bidResponse, List<BidderError> errors) { |
There was a problem hiding this comment.
the errors list is redundant
| private BidType getBidType(Bid bid) { | ||
| final Integer markupType = ObjectUtils.defaultIfNull(bid.getMtype(), 0); | ||
|
|
||
| return switch (markupType) { | ||
| case 1 -> BidType.banner; | ||
| default -> throw new PreBidException( | ||
| "could not define media type for impression: " + bid.getImpid()); | ||
| }; | ||
| } |
There was a problem hiding this comment.
that's just not how it works in Go
| @@ -0,0 +1,12 @@ | |||
| adapters: | |||
| kobler: | |||
| endpoint: "https://bid.essrtb.com/bid/prebid_server_rtb_call" | |||
There was a problem hiding this comment.
the endpoint-compression is missed
| BidderDeps koblerBidderDeps(BidderConfigurationProperties koblerConfigurationProperties, | ||
| CurrencyConversionService currencyConversionService, | ||
| @NotBlank @Value("${external-url}") String externalUrl, | ||
| JacksonMapper mapper) { |
There was a problem hiding this comment.
I used a checkstyle and it didnt show mistakes. How it should looks like?
| final ExtImpKobler impExt = parseImpExt(imp); | ||
|
|
||
| if (bidRequest.getImp().indexOf(imp) == 0) { | ||
| testMode = impExt.getTest(); |
There was a problem hiding this comment.
NPE will be thrown if imp.ext.test is NULL
🔧 Type of changes
✨ What's the context?
#3667