Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nothing happens when image is clicked (possible issue with <img> tag?) #2

Closed
kylecrsn opened this issue May 24, 2019 · 1 comment
Closed

Comments

@kylecrsn
Copy link

I followed the instructions and installed the plugin, added it to the gatsby-config.js file like so:

//...
{
  resolve: 'gatsby-transformer-remark',
  options: {
    plugins: [
      {
        resolve: 'gatsby-remark-images',
        options: {
          maxWidth: 1000,
          linkImagesToOriginal: false
        }
      },
      'gatsby-remark-images-zoom',
//...

however clicking on it does nothing.

It would help a lot if the their was a demo site with code available, however comparing against the generated HTML of the demo linked in the readme, I noticed a couple of (likely key) differences compared to my site's code:

Screenshot from 2019-05-24 15-50-01

On the left is my site and on the right is the demo site. Note that

  • The <img> tag on my site isn't nested inside the responsive background image <span>
  • The .medium-zoom-image class is missing from the <img> on my site

Not sure why the tag isn't being nested properly, or if this is some sort of conflicting dependency issue. Any idea on what it might be, or what I could try to resolve it?

@kylecrsn
Copy link
Author

Something must've gone wrong while installing the package, I nuked my node_modules folder and reinstalled and it started working! (sort of, having the same problem as #1 ), closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant