You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This issue is for tracking a few potential improvements that haven't been made because they would require changes to Porymap. This way if it's decided one breaking change should be made the rest can be easily referred to and piled on.
Additional constants in include/constants/heal_locations.h aren't preserved by Porymap, which prevents adding HEAL_LOCATION_NONE. See Add the HEAL_LOCATION_NONE constant #1671
MAP_NONE is more accurately MAP_DYNAMIC, and MAP_UNDEFINED would be MAP_NONE. This could be updated, but Porymap currently hard codes "MAP_NONE" as "None" and expects any other MAP_ constant in a warp destination field to be a valid map, or it rejects the event. See Rename special map constants, treat warp ids as strings #1755
The text was updated successfully, but these errors were encountered:
BuffelSaft
pushed a commit
to BuffelSaft/pokeemerald
that referenced
this issue
Nov 22, 2021
With the recent changes to support enums in assembly, I'm anticipating that Porymap will need to be able to deal with enums in some places that it currently expects #define. (Support for parsing enums huderlem/porymap#606)
This issue is for tracking a few potential improvements that haven't been made because they would require changes to Porymap. This way if it's decided one breaking change should be made the rest can be easily referred to and piled on.
object_event_graphics_info.h
could be made more readable and less prone to errors from missing a field by using designated initializers (see Use designated initializers for object_event_graphics_info.h #1413). Porymap is currently unable to parse this.graphics/pokenav
are organized into subfolders, except for those read/written by Porymap whose paths would need to be updated. See Updates to region map for Porymap #1636dest_warp_id
field because Porymap treats this as an int and won't properly handle macro names. See Rename special map constants, treat warp ids as strings #1755include/constants/heal_locations.h
aren't preserved by Porymap, which prevents addingHEAL_LOCATION_NONE
. See Add the HEAL_LOCATION_NONE constant #1671data/tilesets.s
is still in assembly is because Porymap expects it to be. Related: Convert map JSON data to C instead of asm #1736MAP_NONE
is more accuratelyMAP_DYNAMIC
, andMAP_UNDEFINED
would beMAP_NONE
. This could be updated, but Porymap currently hard codes "MAP_NONE
" as "None" and expects any otherMAP_
constant in a warp destination field to be a valid map, or it rejects the event. See Rename special map constants, treat warp ids as strings #1755The text was updated successfully, but these errors were encountered: