Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversions #74

Closed
wants to merge 18 commits into from
Closed

Conversions #74

wants to merge 18 commits into from

Conversation

mikapfl
Copy link
Member

@mikapfl mikapfl commented Sep 23, 2021

Pull request

Please confirm that this pull request has done the following:

  • Tests added
  • Documentation added (where applicable)
  • Description in a .rst file in the directory changelog_unreleased added - remember to include a * to make it a bullet point

Description

Please provide a short description what your pull request does.

@mikapfl
Copy link
Member Author

mikapfl commented Sep 23, 2021

Needs a new release of climate_categories with conversion support.

@codecov
Copy link

codecov bot commented Nov 2, 2021

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (23b9c1c) 97.16% compared to head (a76feea) 96.83%.

Files Patch % Lines
primap2/_convert.py 89.36% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #74      +/-   ##
==========================================
- Coverage   97.16%   96.83%   -0.33%     
==========================================
  Files          34       36       +2     
  Lines        3102     3259     +157     
==========================================
+ Hits         3014     3156     +142     
- Misses         88      103      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikapfl
Copy link
Member Author

mikapfl commented Nov 5, 2021

Soo... this is the status:

  • Conversion of DataArrays smoke-tested (means, I can convert something without getting an exception)
  • Datasets not yet supported
  • no docs
  • no real tests
  • performance still bad
  • Datasets not yet supported

I mostly know what to do for all of these points:

  • 3-4 hours work for docs
  • 1-2 days work for real tests. There's a lot to test here, unfortunately.
  • 4-5 hours of work for better performance. At the moment, a lot of objects are copied around, would need to test different ways to do it to find which one performs well enough.
  • 1 day for limited Dataset support, meaning support for entities in auxiliary categories, but no support for converting entities (which would need more involved unit handling). Includes tests and docs for Datasets.

It is more work than I thought, especially writing somewhat comprehensive tests.

@mikapfl
Copy link
Member Author

mikapfl commented Nov 15, 2023

TODO:

  • performance
  • docs
  • comprehensive tests
  • dataset support:
    • convert category and use auxiliary category in arrays
    • use entity as auxiliary category

@mikapfl
Copy link
Member Author

mikapfl commented Oct 7, 2024

@crdanielbusch I've merged main into this branch and brought all parts up to speed with the recent refactorings. At least the existing minimal test passes now. (-:

@JGuetschow JGuetschow linked an issue Oct 8, 2024 that may be closed by this pull request
@crdanielbusch crdanielbusch mentioned this pull request Oct 10, 2024
3 tasks
@mikapfl mikapfl closed this Oct 10, 2024
@mikapfl mikapfl deleted the conversions branch October 10, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pyCPA port: tools.conversion.map_data
1 participant