Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recommendation to move type to dependency #32

Open
privatenumber opened this issue Feb 16, 2023 · 2 comments
Open

Recommendation to move type to dependency #32

privatenumber opened this issue Feb 16, 2023 · 2 comments

Comments

@privatenumber
Copy link
Owner

privatenumber commented Feb 16, 2023 •
edited
Loading

The recommendation to move type to dependency should only happen when bundling types:

Recommendation: "@types/ini" is externalized because "ini" is in "dependencies". Place "@types/ini" in "dependencies" as well so users don't have missing types.

And ideally, if the type dependency is imported.
@ksv90
Copy link

ksv90 commented Aug 1, 2024

Are there any plans to fix this?

@privatenumber
Copy link
Owner Author

privatenumber commented Aug 1, 2024 •
edited
Loading

Yes but not a priority for me. Feel free to submit a PR if you'd like!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@privatenumber @ksv90