Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simulating multiple genetically correlated phenotypes #419

Open
fmorgante opened this issue Apr 10, 2023 · 7 comments
Open

Simulating multiple genetically correlated phenotypes #419

fmorgante opened this issue Apr 10, 2023 · 7 comments

Comments

@fmorgante
Copy link

Hi Florian, thank you for a great package! I think it would be very useful if snp_simuPheno could be extended to simulate multiple genetically correlated phenotypes. I guess the framework could be made as flexible as one wants, but a great first step would be to allow for the effects to be drawn from a multivariate normal with mean 0 and a user-provided covariance matrix across traits, and independent residuals across traits.

Do you think this is something you are interested in implementing?

@privefl
Copy link
Owner

privefl commented Apr 11, 2023

Yes, this is definitely something interesting to have.
E.g. see https://github.com/privefl/bigsnpr/blob/master/tmp-tests/test-gen-cor.R#L39-L53.

I guess it becomes a bit tricky if you consider that the two phenotypes can have different causal variants.

@fmorgante
Copy link
Author

Yes, absolutely. I guess you could start by imposing the same causal variants across traits, but allowing an arbitrary number of traits. The user would then provide the desired genetic correlation matrix

@privefl
Copy link
Owner

privefl commented Apr 11, 2023

Yes, that should be doable. Something like providing matrix of genetic correlations + vector of heritabilities might be easier than directly the covariance matrix.

@fmorgante
Copy link
Author

That sounds great!

@privefl
Copy link
Owner

privefl commented Apr 12, 2023

Do you want to try to implement it?

@fmorgante
Copy link
Author

I do not have bandwidth at the moment, but I may be able to get to it later in the summer (if you or someone else does not do it before). I suggest we keep this issue open until someone implements this. What do you think?

@privefl
Copy link
Owner

privefl commented Apr 13, 2023

Same. Sounds like a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants