You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Re probot/probot#620 and probot/template#79 we want to extend create-probot-app to work for multiple use cases in the same repo. The current library we use for that is egad's scaffold which wasn't designed for our usecase in several ways.
Most importantly right now it doesn't support just cloning a folder from a git repo. In fact, I'm struggling to find a library that does do that. So I started out writing it using our get contents API; however, it's really hard to handle directories within directories without some recursion. You can check out what I started here (naturally I committed my PAT 🤦♂️ ); however, at this point I'm leaning towards just having different templates in different branches instead of folders. That set up is supported by our existing frameworks.
I'd love to hear other thoughts/if folders feel important enough for this additional complexity to the create-probot-app script, or if branches might be simpler.
cc/ @probot/maintainers
The text was updated successfully, but these errors were encountered:
For posterity, @hiimbex and I talked through a couple alternatives:
Move the templates into this repository and distribute them with the create-probot-app package. This will require copying over the templating features form egad, but it's not that much code.
Update egad or something similar to support subdirectories. it might still require cloning the entire repo (or downloading the zip from GitHub), but it could just use the subdirectory to for templating.
Re probot/probot#620 and probot/template#79 we want to extend create-probot-app to work for multiple use cases in the same repo. The current library we use for that is egad's scaffold which wasn't designed for our usecase in several ways.
Most importantly right now it doesn't support just cloning a folder from a git repo. In fact, I'm struggling to find a library that does do that. So I started out writing it using our get contents API; however, it's really hard to handle directories within directories without some recursion. You can check out what I started here (naturally I committed my PAT 🤦♂️ ); however, at this point I'm leaning towards just having different templates in different branches instead of folders. That set up is supported by our existing frameworks.
I'd love to hear other thoughts/if folders feel important enough for this additional complexity to the create-probot-app script, or if branches might be simpler.
cc/ @probot/maintainers
The text was updated successfully, but these errors were encountered: