Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Difficult to extend for use case templates #34

Closed
hiimbex opened this issue Aug 29, 2018 · 2 comments
Closed

Difficult to extend for use case templates #34

hiimbex opened this issue Aug 29, 2018 · 2 comments
Labels

Comments

@hiimbex
Copy link
Contributor

hiimbex commented Aug 29, 2018

Re probot/probot#620 and probot/template#79 we want to extend create-probot-app to work for multiple use cases in the same repo. The current library we use for that is egad's scaffold which wasn't designed for our usecase in several ways.

Most importantly right now it doesn't support just cloning a folder from a git repo. In fact, I'm struggling to find a library that does do that. So I started out writing it using our get contents API; however, it's really hard to handle directories within directories without some recursion. You can check out what I started here (naturally I committed my PAT 🤦‍♂️ ); however, at this point I'm leaning towards just having different templates in different branches instead of folders. That set up is supported by our existing frameworks.

I'd love to hear other thoughts/if folders feel important enough for this additional complexity to the create-probot-app script, or if branches might be simpler.
cc/ @probot/maintainers

@bkeepers
Copy link
Contributor

For posterity, @hiimbex and I talked through a couple alternatives:

  1. Move the templates into this repository and distribute them with the create-probot-app package. This will require copying over the templating features form egad, but it's not that much code.
  2. Update egad or something similar to support subdirectories. it might still require cloning the entire repo (or downloading the zip from GitHub), but it could just use the subdirectory to for templating.

cc @boneskull

@stale
Copy link

stale bot commented Nov 27, 2018

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

@stale stale bot added the wontfix label Nov 27, 2018
@stale stale bot closed this as completed Dec 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants