-
Notifications
You must be signed in to change notification settings - Fork 28
/
Copy pathSAAFError.py
690 lines (498 loc) · 21.7 KB
/
SAAFError.py
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
# Copyright (c) 2015, Fundacion Dr. Manuel Sadosky
# All rights reserved.
# Redistribution and use in source and binary forms, with or without
# modification, are permitted provided that the following conditions are met:
# 1. Redistributions of source code must retain the above copyright notice, this
# list of conditions and the following disclaimer.
# 2. Redistributions in binary form must reproduce the above copyright notice,
# this list of conditions and the following disclaimer in the documentation
# and/or other materials provided with the distribution.
# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
# AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
# IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
# DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE
# FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
# DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
# SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
# CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
# OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
import abc
from Utils import *
import binascii
import base64
import settings
class SAAFError(object):
# The class of all errors found with SAAF Module
def __init__(self, element):
self.element = element
@classmethod
def get_validators(self, element):
# ask for subclasses and find wich one can validate the element
subclasses = get_subclasses(SAAFError)
responders = []
# print subclasses
for subclass in subclasses:
if subclass.can_validate(element):
responders.append(subclass(element)) #create subclass
return responders
@classmethod
def can_validate(cls, element):
return element.get('pattern').find(cls.get_error_code()) != -1
@abc.abstractmethod
def get_error_code(cls):
return "This doesn't match anything"
def get_vuln_code(cls):
return "ABSTRACT"
@abc.abstractmethod
def get_confidence(self):
return 0
@abc.abstractmethod
def do_dynamic_analysis(self):
return False
@abc.abstractmethod
def get_dynamic_params(self):
return
def get_reference_class(self):
return self.element.get('file')
def get_reference_method(self):
#format: class : .method method_signature
return self.element.get('method').split(':')[1]
def is_constant(self):
return self.element.get('variable-type') in {'FIELD_CONSTANT', 'LOCAL_ANONYMOUS_CONSTANT'} or\
(self.element.get('variable-type') == 'ARRAY' and self.element.get('value').startswith('['))
def is_accurate(self):
return int(self.element.get('fuzzy-level')) <= settings.FUZZY_LEVEL_THRESHOLD
def validate(self):
return self.is_constant() and self.is_accurate()
class WebViewSavedPassword(SAAFError):
def __init__(self, element):
super(WebViewSavedPassword, self).__init__(element)
@classmethod
def get_error_code(cls):
return "Webview saved password"
def validate(self):
constant = self.element.get('variable-type') in {'FIELD_CONSTANT', 'LOCAL_ANONYMOUS_CONSTANT'}
variable = self.element.get('value')
return variable == '1'
def get_vuln_code(cls):
return "WEBVIEW_SAVED_PASSWORD"
def get_confidence(self):
return 1
def do_dynamic_analysis(self):
return False
def get_dynamic_params(self):
return None
def get_report(self):
return "WebView is storing passwords insecurely."
class StickyBroadcastIntent(SAAFError):
def __init__(self, element):
super(StickyBroadcastIntent, self).__init__(element)
@classmethod
def get_error_code(cls):
return "Sticky Broadcast"
def validate(self):
return True
def get_vuln_code(cls):
return "STICKY_BROADCAST_INTENT"
def get_confidence(self):
return 1
def do_dynamic_analysis(self):
return False
def get_dynamic_params(self):
return None
def get_report(self):
return "A sticky broadcast intent is being sent by the application. They shouldn't be used since they provide no security (anyone can access them), no protection (anyone can modify them), and many other problems"
class AutoCompletePasswordInput(SAAFError):
def __init__(self, element):
super(AutoCompletePasswordInput, self).__init__(element)
@classmethod
def get_error_code(cls):
return "Autocompleted password input"
def validate(self):
constant = self.element.get('variable-type') in {'FIELD_CONSTANT', 'LOCAL_ANONYMOUS_CONSTANT'}#,'LOCAL_VARIABLE','MATH_OPCODE_CONSTANT'}
variable = self.element.get('value')
# explicit has mode WORLD_READEABLE or WRITEABLE
# TYPE_NUMBER_VARIATION_PASSWORD 16
# TYPE_TEXT_VARIATION_VISIBLE_PASSWORD 144
#TYPE_TEXT_VARIATION_WEB_PASSWORD 224
#TYPE_TEXT_VARIATION_PASSWORD 128
value = int(variable)
return constant and ( value & 16 != 16 or value & 144 != 144 or value & 224 != 224 or value & 128 != 128 )
def get_vuln_code(cls):
return "AUTOCOMPLETE_PASSWORD_INPUT"
def get_confidence(self):
return 1
def do_dynamic_analysis(self):
return False
def get_dynamic_params(self):
return None
# TODO: Check XML layout for inputType
def get_report(self):
return "Application is using an AutoCompleteTextView for a password input field. This can cause the user's dictionary to remember the user's password"
class ModeWorldReadableOrWriteableStorage(SAAFError):
def __init__(self, element):
super(ModeWorldReadableOrWriteableStorage, self).__init__(element)
@classmethod
def get_error_code(cls):
return "Mode WORLD_READABLE/WRITEABLE abstract"
def validate(self):
constant = self.element.get('variable-type') in {'FIELD_CONSTANT', 'LOCAL_ANONYMOUS_CONSTANT'} #,'LOCAL_VARIABLE','MATH_OPCODE_CONSTANT'}
variable = self.element.get('value')
# explicit has mode WORLD_READEABLE or WRITEABLE
## do not do fuzzy-level greater than 1
return int(self.element.get('fuzzy-level')) <= 1 and constant and ( variable == '1' or variable == '2')
def get_vuln_code(cls):
return "INSECURE_STORAGE_WORLD_READABLE/WRITEABLE"
def get_confidence(self):
return 1 - int(self.element.get('fuzzy-level')) / 10
def do_dynamic_analysis(self):
return False
def get_dynamic_params(self):
return None
def get_report(self):
return "is being opened by the application using WORLD_READABLE/WRITEABLE. This is dangerous and likely to cause security holes in the application."
class ModeWorldReadableOrWriteableFile(ModeWorldReadableOrWriteableStorage):
@classmethod
def get_error_code(cls):
return "Mode WORLD_READABLE/WRITEABLE File"
def get_report(self):
return "A file " + super(ModeWorldReadableOrWriteableFile, self).get_report()
class ModeWorldReadableOrWriteableDatabase(ModeWorldReadableOrWriteableStorage):
@classmethod
def get_error_code(cls):
return "Mode WORLD_READABLE/WRITEABLE Database"
def get_report(self):
return "A database " + super(ModeWorldReadableOrWriteableDatabase, self).get_report()
class ModeWorldReadableOrWriteableSharedPreference(ModeWorldReadableOrWriteableStorage):
@classmethod
def get_error_code(cls):
return "Mode WORLD_READABLE/WRITEABLE SharedPreference"
def get_report(self):
return "A shared preference file " + super(ModeWorldReadableOrWriteableSharedPreference, self).get_report()
class InsecureClassLoaderPath(SAAFError):
def __init__(self, element):
super(InsecureClassLoaderPath, self).__init__(element)
@classmethod
def get_error_code(cls):
return "Insecure PathClassLoader"
def validate(self):
method_call = self.element.get('variable-type') in {'EXTERNAL_METHOD'}
constant = self.element.get('variable-type') in {'FIELD_CONSTANT', 'LOCAL_ANONYMOUS_CONSTANT' }#,'LOCAL_VARIABLE','MATH_OPCODE_CONSTANT'}
variable = self.element.get('value')
return (method_call and 'getExternal' in variable)\
or (constant and '/sdcard' in variable)
def get_vuln_code(cls):
return "INSECURE_PATHCLASSLOADER"
def get_confidence(self):
return 1 - int(self.element.get('fuzzy-level')) / 10
def do_dynamic_analysis(self):
return False
def get_dynamic_params(self):
return None
def get_report(self):
return "The application is dynamically loading classes from the external storage. This could allow an attacker to execute code as the application."
class InsecureExec(SAAFError):
def __init__(self, element):
super(InsecureExec, self).__init__(element)
@classmethod
def get_error_code(cls):
return "Execute external program"
def validate(self):
#TODO: Check for other file sources
method_call = self.element.get('variable-type') in {'EXTERNAL_METHOD'}
variable = self.element.get('value')
read_from_file = variable in ('java/io/RandomAccessFile->readLine()','java/io/BufferedReader->readLine()','java/io/InputStreamReader->read([C)')
read_from_input = 'android/content/Intent->get' in variable
read_from_sharedpreference = 'android/content/SharedPreferences->get' in variable
read_from_network = 'org/apache/http/HttpResponse' in variable or 'java/net/URLConnection' in variable
return method_call and (read_from_file or read_from_input or read_from_sharedpreference or read_from_network)
def get_vuln_code(cls):
return "INSECURE_RUNTIME_EXEC_COMMAND"
def get_confidence(self):
return 1 - int(self.element.get('fuzzy-level')) / 10
def do_dynamic_analysis(self):
return False
def get_dynamic_params(self):
return None
def get_report(self):
return "The application is executing a command from an insecure source input."
class JavascriptInterface(SAAFError):
def __init__(self, element):
super(JavascriptInterface, self).__init__(element)
@classmethod
def get_error_code(cls):
return "Webview addJavascriptInterface"
def validate(self):
return super(JavascriptInterface, self).validate()
def get_vuln_code(cls):
return "JAVASCRIPTINTERFACE"
def get_confidence(self):
return 1 - int(self.element.get('fuzzy-level')) / 10
def do_dynamic_analysis(self):
return True
def get_dynamic_params(self):
return {"interface": self.element.get('value').replace("\"", "")}
def get_report(self):
return "A Javascript Interface found. It's name is: %s" % (self.element.get('value').replace("\"", "") )
class CryptoError(SAAFError):
def __init__(self, element):
super(CryptoError, self).__init__(element)
@classmethod
def get_error_code(cls):
return "This doesn't match anything"
def validate(self):
return super(CryptoError, self).validate()
def get_vuln_code(cls):
return "CRYPTOGRAPHY"
def get_confidence(self):
return 1 - int(self.element.get('fuzzy-level')) / 10
def do_dynamic_analysis(self):
return False
def get_dynamic_params(self):
return None
@abc.abstractmethod
def get_message(self):
return
@abc.abstractmethod
def get_report(self):
return ""
class TwitterConsumerKey(CryptoError):
def __init__(self, element):
super(TwitterConsumerKey, self).__init__(element)
@classmethod
def get_error_code(cls):
return 'Twitter\'s consumer secret analysis'
def validate(self):
if not super(TwitterConsumerKey, self).validate():
return False
if self.element.get('variable-description') == 'java/lang/String':
variable = self.element.get('value')
# only if the parameter's length looks like a secret twitter consumer secret length increases over time
return len(variable) > 30
return False
def get_report(self):
return "Has a hardcoded Twitter consumer secret key: " + self.element.get('value')
class SMTPHardcodedKey(CryptoError):
def __init__(self, element):
super(SMTPHardcodedKey, self).__init__(element)
@classmethod
def get_error_code(cls):
return 'Hardcoded SMTP Password'
def validate(self):
if not super(SMTPHardcodedKey, self).validate():
return False
if self.element.get('variable-description') == 'java/lang/String':
variable = self.element.get('value')
# only if the parameter's length looks like a key
return len(variable) > 6
return False
def get_report(self):
return "Has a hardcoded SMTP password: " + self.element.get('value')
class ECBModeEncryption(CryptoError):
def __init__(self, element):
super(ECBModeEncryption, self).__init__(element)
@classmethod
def get_error_code(cls):
return 'Encryption algorithm analysis'
def validate(self):
if not super(ECBModeEncryption, self).validate():
return False
variable = self.element.get('value').replace("\"", "")
# explicit contains ECB or only contains block cipher
return variable.find('AES/ECB') != -1 or variable.find(
'DES/ECB') != -1 or variable == 'AES' or variable == 'DES'
def get_report(self):
return "Uses ECB encryption mode"
class InsecureCipher(CryptoError):
def __init__(self, element):
super(InsecureCipher, self).__init__(element)
@classmethod
def get_error_code(cls):
return 'Encryption algorithm analysis'
def validate(self):
if not super(InsecureCipher, self).validate():
return False
variable = self.element.get('value').replace("\"", "")
insecure_cipher_keyword_list = { "null","anon","des","rc4","rc2"}
# explicit contains any of the keywords
in_keywords = any(variable.lower().find(keyword) != -1 for keyword in insecure_cipher_keyword_list)
return self.is_constant() and in_keywords
def get_report(self):
return "Uses insecure cipher "+self.element.get('value').replace("\"", "")
class InsecureDigest(CryptoError):
def __init__(self, element):
super(InsecureDigest, self).__init__(element)
@classmethod
def get_error_code(cls):
return 'Digest algorithm analysis'
def validate(self):
if not super(InsecureDigest, self).validate():
return False
variable = self.element.get('value').replace("\"", "")
insecure_cipher_keyword_list = { "md5"}
# explicit contains any of the keywords
in_keywords = any(variable.lower().find(keyword) != -1 for keyword in insecure_cipher_keyword_list)
return self.is_constant() and in_keywords
def get_report(self):
return "Uses insecure digest "+self.element.get('value').replace("\"", "")
class HardcodedValue(CryptoError):
def __init__(self, element):
super(HardcodedValue, self).__init__(element)
# PARENT OF BOTH HARDCODED IV AND KEY, THEY HAVE THE SAME VALIDATOR
@classmethod
def get_error_code(cls):
return "This doesn't match anything"
def validate(self):
if not super(HardcodedValue, self).validate():
return False
# if it's a hardcoded array
isConstant = self.is_constant()
if self.element.get('variable-type') == 'ARRAY':
#is a hardcoded array
return isConstant
# if it's a string
if self.element.get('variable-description') == 'java/lang/String':
variable = self.element.get('value')
#only if the parameter's length looks like an AES or DES key? What about SHA1 and other keys?
isFuzzyZero = int(self.element.get('fuzzy-level')) == 0 and len(variable) > 8
isAESorDES = ( len(variable) <= 34 and len(variable) >= 30) or (
len(variable) <= 18 and len(variable) >= 14)
isLargerThan64 = len(variable) >= 64
try:
decode = base64.decodestring(variable[1:len(variable) - 1])
isBase64 = len(decode) > 8
except binascii.Error:
isBase64 = False
return isConstant and (isFuzzyZero or isBase64 or isAESorDES or isLargerThan64)
return False
@abc.abstractmethod
def get_report(self):
return
class HardcodedSeedRandom(HardcodedValue):
def __init__(self, element):
super(HardcodedSeedRandom, self).__init__(element)
@classmethod
def get_error_code(cls):
return "Hardcoded Seed of Secure Random"
def validate(self):
#an hardcoded array or a long with fuzzy level zero
return self.is_constant() and (self.element.get('variable-type') == 'ARRAY' or int(self.element.get('fuzzy-level')) == 0)
def get_report(self):
return "Uses a harcoded seed for SecureRandom " + self.element.get('value')
class HardcodedKey(HardcodedValue):
def __init__(self, element):
super(HardcodedKey, self).__init__(element)
@classmethod
def get_error_code(cls):
return 'Hardcoded crypto key'
def get_report(self):
return "Has a hardcoded key " + self.element.get('value')
class HardcodedIV(HardcodedValue):
def __init__(self, element):
super(HardcodedIV, self).__init__(element)
@classmethod
def get_error_code(cls):
return 'Hardcoded IV analysis'
def get_report(self):
return "Has a hardcoded IV " + self.element.get('value')
class PBEHardcodedKey(HardcodedValue):
def __init__(self, element):
super(PBEHardcodedKey, self).__init__(element)
@classmethod
def get_error_code(cls):
return 'Hardcoded password of PBE'
def get_report(self):
return "Password based encryption has a hardcoded key " + self.element.get('value')
class PBEHardcodedSalt(HardcodedValue):
def __init__(self, element):
super(PBEHardcodedSalt, self).__init__(element)
@classmethod
def get_error_code(cls):
return 'Hardcoded salt of PBE'
def get_report(self):
return "Password based encryption has a hardcoded salt " + self.element.get('value')
class PBELowIteration(CryptoError):
def __init__(self, element):
super(PBELowIteration, self).__init__(element)
@classmethod
def get_error_code(cls):
return 'Low number of iterations of PBE'
def validate(self):
try:
#only get fuzzy-level zero, too many false positives
return int(self.element.get('fuzzy-level')) == 0 and self.is_constant() and int(self.element.get('value')) < 1000
except ValueError:
return False
def get_report(self):
return "Low number of iterations for PBE encryption %d" % int(self.element.get('value'))
class BaaSApiKey(HardcodedValue):
def __init__(self, element):
super(BaaSApiKey, self).__init__(element)
@classmethod
def get_error_code(cls):
return "BaaS Abstract"
def get_vuln_code(cls):
return "BAAS_ABSTRACT"
def do_dynamic_analysis(self):
return False
def get_dynamic_params(self):
return None
def get_report(self):
return "is being used by the application. The key for this service is "+ self.element.get('value')
class ParseBaaSApiKey(BaaSApiKey):
@classmethod
def get_error_code(cls):
return "Parse BaaS"
def get_vuln_code(cls):
return "BAAS_PARSE"
def get_report(self):
return "Parse BaaS service " + super(ParseBaaSApiKey, self).get_report()
class AWSBaaSApiKey(BaaSApiKey):
@classmethod
def get_error_code(cls):
return "AWS BaaS"
def get_vuln_code(cls):
return "BAAS_AWS"
def get_report(self):
return "AWS BaaS service " + super(AWSBaaSApiKey, self).get_report()
class CloudMineBaaSApiKey(BaaSApiKey):
@classmethod
def get_error_code(cls):
return "CloudMine BaaS"
def get_vuln_code(cls):
return "BAAS_CLOUDMINE"
def get_report(self):
return "CloudMine service " + super(CloudMineBaaSApiKey, self).get_report()
class AzureBaaSApiKey(BaaSApiKey):
@classmethod
def get_error_code(cls):
return "Azure BaaS"
def get_vuln_code(cls):
return "BAAS_AZURE"
def get_report(self):
return "Azure service " + super(AzureBaaSApiKey, self).get_report()
class ApacheCredentialHardcodedUsername(HardcodedValue):
def __init__(self, element):
super(ApacheCredentialHardcodedUsername, self).__init__(element)
@classmethod
def get_error_code(cls):
return 'Apache credentials hardcoded username'
def get_report(self):
return "Has Apache credentials hardcoded username " + self.element.get('value')
class ApacheCredentialHardcodedPassword(HardcodedValue):
def __init__(self, element):
super(ApacheCredentialHardcodedPassword, self).__init__(element)
@classmethod
def get_error_code(cls):
return 'Apache credentials hardcoded password'
def get_report(self):
return "Has Apache credentials hardcoded password " + self.element.get('value')
class ApacheCredentialHardcodedUsernameAndPassword(HardcodedValue):
def __init__(self, element):
super(ApacheCredentialHardcodedUsernameAndPassword, self).__init__(element)
@classmethod
def get_error_code(cls):
return 'Apache credentials username and password'
def get_report(self):
return "Has Apache credentials hardcoded " + self.element.get('value')