Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust upgrade e2e test to pause Job before upgrade #426

Closed
sutaakar opened this issue Dec 12, 2023 · 0 comments · Fixed by #427
Closed

Adjust upgrade e2e test to pause Job before upgrade #426

sutaakar opened this issue Dec 12, 2023 · 0 comments · Fixed by #427
Assignees

Comments

@sutaakar
Copy link
Contributor

Name of Feature or Improvement

Adjust upgrade e2e test to pause Job before upgrade

Description of Problem the Feature Should Solve

Right now the upgrade e2e test is unreliable in the sense that the test depends on operator upgrade to be invoked right after TestMNISTCreateAppWrapper finishes. In case of any larger delay the old operator finishes AppWrapper processing, making the test worthless.

Describe the Solution You Would Like to See

This PR makes sure that Job created by AppWrapper is suspended, resumed by TestMNISTCheckAppWrapperStatus. As a result the upgrade test is not dependent on operator upgrade timing, as upgraded operator is running when TestMNISTCheckAppWrapperStatus is invoked.

Describe Alternatives You Have Considered

N/A

Additional Context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

1 participant